Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency to jean85/pretty-package-versions #805

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Dec 12, 2023

Thanks to Composer API v2, we have an easy solution to retrieve the version of a package that is installed.

@GromNaN GromNaN added the Task label Dec 12, 2023
@GromNaN GromNaN added this to the 5.0.0 milestone Dec 12, 2023
Copy link
Member

@malarzm malarzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 👌

@malarzm malarzm merged commit cfeb317 into doctrine:5.0.x Dec 12, 2023
14 checks passed
@malarzm
Copy link
Member

malarzm commented Dec 12, 2023

Thanks @GromNaN! Will you be making similar adjustment to ODM itself? I think we were using same package there as well

@GromNaN GromNaN deleted the composer-version branch December 12, 2023 14:29
@GromNaN
Copy link
Member Author

GromNaN commented Dec 12, 2023

Yes, I'd like to do the same for other projects : ODM and mongodb library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants