Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODM 2.0 support? #205

Closed
metanav opened this issue Oct 1, 2018 · 14 comments · Fixed by #222
Closed

ODM 2.0 support? #205

metanav opened this issue Oct 1, 2018 · 14 comments · Fixed by #222
Labels
BC Break Enhancement New feature or request

Comments

@metanav
Copy link

metanav commented Oct 1, 2018

doctrine/mongodb-odm 2.00-alpha1 has been released recently. Is there any plan to upgrade doctrine/DoctrineMongoODMModule? All of my applications use Zend framework so I am not able to test the new version.

@Ocramius
Copy link
Member

Ocramius commented Oct 1, 2018

@metanav you can try it yourself via "require": {"doctrine/mongodb-odm": "2.0.0-alpha1 as 1.99.99"}

@Ocramius Ocramius closed this as completed Oct 1, 2018
@metanav
Copy link
Author

metanav commented Oct 1, 2018

@Ocramius there is an upgrade guide which says there are some changes:

"The constructor signature of Doctrine\ODM\MongoDB\DocumentManager as well as the create, getClient, getDocumentDatabase, getDocumentCollection, and getDocumentCollections methods have been updated to handle classes from mongodb/mongodb instead of doctrine/mongodb."

I was just checking if doctrine/DoctrineMongoODMModule will work as is?

@Ocramius
Copy link
Member

Ocramius commented Oct 1, 2018

It will most likely not - changes will need to be made here as well, hence why I suggested you attempt an upgrade and see how much breaks.

@metanav
Copy link
Author

metanav commented Oct 1, 2018

I see, thanks!

@alcaeus
Copy link
Member

alcaeus commented Oct 1, 2018

I can tell you that the module is most likely not going to work with 2.0 without adjustments. I'll see when I can get to it, however the focus is on ODM itself and the Symfony bundle (as that's what I use personally). Contributions to the module are highly welcome.

@alcaeus alcaeus reopened this Oct 1, 2018
@alcaeus alcaeus added BC Break Enhancement New feature or request labels Oct 1, 2018
@metanav
Copy link
Author

metanav commented May 7, 2019

@alcaeus Is there any plan to update it anytime soon? Please let me know if I can help, might need some guidance to start.

@alcaeus
Copy link
Member

alcaeus commented May 7, 2019

I most likely won't have time to work on this over the next weeks. You can take a look at the corresponding bundle PR: doctrine/DoctrineMongoDBBundle#475 that brings basic compatibility with 2.0. If you have any questions, please don't hesitate contacting me here or in either the Symfony or Doctrine Slacks.

@datasage
Copy link

To avoid duplicating efforts, is someone already working on upgrading this to support 2.0 already?

@alcaeus
Copy link
Member

alcaeus commented Nov 29, 2019

Doctrine itself is not working on it.

@TomHAnderson
Copy link
Member

It appears this will be a goal of the develop branch for Laminas.

@rieschl
Copy link
Contributor

rieschl commented Mar 4, 2020

It appears this will be a goal of the develop branch for Laminas.

@TomHAnderson are you working on updating to odm 2.0? Because I did some work on that some time ago (very unfinisehd but already working basically) but stopped then because I'll probably need that to work on mezzio, too. I would rather do something like this one: https://github.com/DASPRiD/container-interop-doctrine.
Either way, do you want to see my progress so far? I'll probably need to rebase it onto develop, though.

@TomHAnderson
Copy link
Member

@rieschl I am not working towards ODM 2.0.

The develop branch here is in a working state and I just added Docker for testing (see the end of the README on develop for details). I would love to see what you have. Please create a PR on develop and let's go from there.

@TomHAnderson
Copy link
Member

@rieschl I had the impression you would add odm 2.0 support to this develop branch. The project is waiting on these changes. Can you give me a timeline for when you can put a PR in place?

If your situation has changed and you won't be doing this please let me know and I'll release this with the old odm version. I would much prefer to include your work.

@rieschl
Copy link
Contributor

rieschl commented Mar 13, 2020

@TomHAnderson Sorry. In the meantime I improved the code a bit but it's unfinished, so I don't think you can publish that. But due to the COVID incident I currently don't have much time to work on the code, but as soon I have some time I'll push it of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC Break Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants