-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare bundle for ODM 2.0 #475
Conversation
32f92ec
to
4081d9f
Compare
Query logging and profiling is now taken care of. The The changes in this PR showed me that I forgot a few additional options that need to be deprecated, so we'll most likely have another minor release (3.6) containing the last few deprecations. This would also serve as a last PHP 5 compatible release that would be supported along ODM 1.3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't go through tests but src changes look good 👍
APM/PSRCommandLogger.php
Outdated
/** @var bool */ | ||
private $registered = false; | ||
|
||
/** @var LoggerInterface */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to ctor this can be nullable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, good catch. Thanks!
4081d9f
to
c18f591
Compare
ext-mongodb
(needsReplace QueryLogger in tests with CommandLogger mongodb-odm#1866)
ext-mongodb