Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare bundle for ODM 2.0 #475

Merged
merged 12 commits into from
Sep 28, 2018
Merged

Prepare bundle for ODM 2.0 #475

merged 12 commits into from
Sep 28, 2018

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Sep 24, 2018

  • Drop PHP < 7.2
  • Require development versions of ODM 2.0 (will change as we move into alpha and beta stages)
  • Drop YAML driver
  • Update configuration to instantiate new connection classes
  • Make service repositories compatible with GridFS repositories
  • Use PHPUnit 7.3
  • Update data collectors for ext-mongodb (needs
    Replace QueryLogger in tests with CommandLogger mongodb-odm#1866)
  • Update query logger for ext-mongodb

@alcaeus alcaeus added this to the 4.0.0 milestone Sep 24, 2018
@alcaeus alcaeus self-assigned this Sep 24, 2018
@alcaeus alcaeus changed the title Prepare bundle for ODM 2.0 [WIP] Prepare bundle for ODM 2.0 Sep 24, 2018
@alcaeus alcaeus force-pushed the odm-2.0-support branch 2 times, most recently from 32f92ec to 4081d9f Compare September 28, 2018 12:14
@alcaeus alcaeus changed the title [WIP] Prepare bundle for ODM 2.0 Prepare bundle for ODM 2.0 Sep 28, 2018
@alcaeus
Copy link
Member Author

alcaeus commented Sep 28, 2018

Query logging and profiling is now taken care of. The pretty option for the profiler is now useless and will most likely be dropped. Since we're now logging all commands, any output we show there may simply be run using db.runCommand(...). I don't think it's worth implementing a lot of logic to convert a find command to the corresponding db.query.find() call for the console. Even if, we may as well make that the default behaviour and show raw command documents next to their pretty console equivalents - both options make the option completely obsolete.

The changes in this PR showed me that I forgot a few additional options that need to be deprecated, so we'll most likely have another minor release (3.6) containing the last few deprecations. This would also serve as a last PHP 5 compatible release that would be supported along ODM 1.3.

Copy link
Member

@malarzm malarzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't go through tests but src changes look good 👍

/** @var bool */
private $registered = false;

/** @var LoggerInterface */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to ctor this can be nullable

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants