Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for DBAL Middlewares #708

Merged
merged 3 commits into from
Feb 14, 2022

Conversation

snapshotpl
Copy link
Contributor

No description provided.

@snapshotpl
Copy link
Contributor Author

Looks like not related errors now.

@driehle
Copy link
Member

driehle commented Jan 11, 2022

Could it be an issue with dbal 3.2.0? I saw tests passing for dbal ^3.1.0 with lowest and failing for ^3.1.0 with highest (which installes 3.2.1).

@driehle driehle self-assigned this Jan 11, 2022
@driehle driehle added this to the 5.1.0 milestone Feb 4, 2022
@driehle driehle added the Enhacement New feature or request label Feb 4, 2022
@driehle
Copy link
Member

driehle commented Feb 4, 2022

@snapshotpl Could you please squash 12684f7 into e2f5bd6 and then rebase your changes on the latest 5.1.x branch? This should solve the issues with the broken pipelines.

@snapshotpl
Copy link
Contributor Author

@driehle ready to go

Copy link
Member

@driehle driehle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@driehle driehle merged commit 301b70c into doctrine:5.1.x Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhacement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants