Set version_column_length to 191 to work with MySQL 8.0 and MariaDB 10.5 #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lower version_column_length from 1024 tot 191
driehle
changed the title
driehle
requested changes
Aug 16, 2022
There was a problem hiding this comment.
Thank you for your PR. The failed CI pipeline seems to be unrelated and should be fixed by #723. Could you please rebase your changes on the current 5.2.x branch to see if this fixes your CI issue?
Furthermore, besides config/module.config.php there are a few other places where the column lenght should be changed:
ci/config/ci.config.phpdocs/en/migrations.rsttests/testing.config.php(two times)
Please include these changes as well.
…into module.config-version_column_length-191
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lower version_column_length from 1024 tot 191
Fixes #720