Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.3 support #749

Merged
merged 5 commits into from
Jan 25, 2024
Merged

PHP 8.3 support #749

merged 5 commits into from
Jan 25, 2024

Conversation

TomHAnderson
Copy link
Member

@TomHAnderson TomHAnderson commented Dec 8, 2023 •
edited
Loading

This PR will require at least the following:

Laminas must update their libraries first to support DoctrineModule

@TomHAnderson TomHAnderson changed the title wip - Updated composer and workflow for php 8.3 [wip] Updated composer and workflow for php 8.3 Dec 9, 2023
@TomHAnderson TomHAnderson mentioned this pull request Dec 9, 2023
Closed
@TomHAnderson TomHAnderson mentioned this pull request Dec 20, 2023
Closed
@FabianKoestring
Copy link
Contributor

@TomHAnderson https://github.com/laminas/laminas-cache-storage-adapter-filesystem/releases/tag/2.4.0 has been released with 8.3 support. ✌️

@FabianKoestring
Copy link
Contributor

@TomHAnderson JFYI https://github.com/doctrine/DoctrineModule/releases/tag/6.1.0 has been released. ✌️

@TomHAnderson
Copy link
Member Author 

 - laminas/laminas-developer-tools 2.3.0 requires php ^7.3 || ~8.0.0 || ~8.1.0 -> your php version (8.3.0) does not satisfy that requirement.

The last release of that library doesn't support 8.3: https://github.com/laminas/laminas-developer-tools/blob/2.8.x/composer.json

Unreleased code is moving forward with 8.3 support.

@FabianKoestring
Copy link
Contributor

@TomHAnderson https://github.com/laminas/laminas-developer-tools/releases/tag/2.9.0

@TomHAnderson
Copy link
Member Author

I've reran the checks. There's one problem with MigrationsCommandFactoryTest. The testDefineDependencyFactoryServicesFromConfig test can no longer pass a string as a dependency factory service due to a change in migrations: https://github.com/doctrine/migrations/pull/1363/files#diff-7b97541a9d8f1fd4102229408221c25b9785ad7d9b47cdfcba644ee93a00a0ffR308

The value of the dependency factory service is an id from the service manager.

@TomHAnderson
Updated testDefineDependencyFactoryServicesFromConfig to confirm to new
2f11771 
signature in migrations.

Check failure on line 308 in lib/Doctrine/Migrations/DependencyFactory.php

Roave BC Check
The parameter $service of Doctrine\Migrations\DependencyFactory#setService() changed from no type to a non-contravariant object|

https://github.com/doctrine/migrations/pull/1363/files#diff-7b97541a9d8f1fd4102229408221c25b9785ad7d9b47cdfcba644ee93a00a0ffR308
@TomHAnderson TomHAnderson changed the title [wip] Updated composer and workflow for php 8.3 Updated composer and workflow for PHP 8.3 Jan 19, 2024
@TomHAnderson TomHAnderson changed the title Updated composer and workflow for PHP 8.3 PHP 8.3 support Jan 19, 2024
@TomHAnderson
Copy link
Member Author

See commit 2f11771 for the fix of my last note.

driehle
driehle requested changes Jan 21, 2024
View reviewed changes
Copy link
Member

@driehle driehle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as in doctrine/DoctrineModule#828: Please update PHP version of the other workflows to 8.3, i.e. coding standards, static analysis and composer lint. They need to run with the latest version, as the minimal version is automatically inflected.

@TomHAnderson
Copy link
Member Author

@driehle in doctrine/DoctrineModule#828 (review) you asked the workflows be set to 8.2 though the max version is 8.3. Here you're asking for the same thing but I think you're asking fo 8.3. If the correct version is 8.3 then we'll need to update DoctrineModule too.

@driehle
Copy link
Member

driehle commented Jan 22, 2024

@TomHAnderson Yes, my fault. Should be 8.3 (i.e. the latest).

@fezfez fezfez mentioned this pull request Jan 22, 2024
Closed
@driehle driehle added this to the 6.1.0 milestone Jan 25, 2024
@driehle driehle added the Enhacement New feature or request label Jan 25, 2024
@driehle driehle self-assigned this Jan 25, 2024
@driehle driehle merged commit d9c7fa9 into doctrine:6.1.x Jan 25, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driehle driehle driehle approved these changes

Assignees

@driehle driehle

Labels
Enhacement New feature or request
Projects
None yet
Milestone
6.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@TomHAnderson @FabianKoestring @driehle