-
-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ProxyGenerator::isShortIdentifierGetter in PHP 7.1 does not support nullable types #761
Comments
aurimasniekis
added a commit
to aurimasniekis/common
that referenced
this issue
Jan 13, 2017
Ocramius
added a commit
that referenced
this issue
Jan 13, 2017
Ocramius
added a commit
that referenced
this issue
Jan 13, 2017
Ocramius
added a commit
that referenced
this issue
Jan 13, 2017
Ocramius
added a commit
that referenced
this issue
Jan 13, 2017
Ocramius
added a commit
that referenced
this issue
Jan 13, 2017
Ocramius
added a commit
that referenced
this issue
Jan 13, 2017
Ocramius
pushed a commit
that referenced
this issue
Jan 13, 2017
Ocramius
added a commit
that referenced
this issue
Jan 13, 2017
Ocramius
added a commit
that referenced
this issue
Jan 13, 2017
Ocramius
added a commit
that referenced
this issue
Jan 13, 2017
Ocramius
added a commit
that referenced
this issue
Jan 13, 2017
Ocramius
added a commit
that referenced
this issue
Jan 13, 2017
Ocramius
added a commit
that referenced
this issue
Jan 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ProxyGenerator::isShortIdentifierGetter does not work with PHP7.1 nullable return types.
Does not work
Works
If I understood correctly the
ProxyGenerator::PATTERN_MATCH_ID_METHOD
should be updated to include question mark in return type and test cases to have case with nullable return type.The text was updated successfully, but these errors were encountered: