Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address deprecations from doctrine/persistence #880

Merged
merged 1 commit into from
Jan 13, 2020
Merged

Address deprecations from doctrine/persistence #880

merged 1 commit into from
Jan 13, 2020

Conversation

greg0ire
Copy link
Member

@greg0ire greg0ire commented Dec 18, 2019 •
edited
Loading

The Common portion of the namespace has been removed following a split
of doctrine/common into several packages.

@greg0ire greg0ire force-pushed the address-persistence-deprecations branch from 65945b5 to 0c112bb Compare December 18, 2019 19:21
alcaeus
alcaeus requested changes Dec 19, 2019
View reviewed changes
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to bump the doctrine/persistence dependency to ^1.3.3 as 1.2.x does not have the forward compatibility layer.

@greg0ire
Address deprecations from doctrine/persistence
90cbf94 
The "Common" portion of the namespace has been removed following a split
of doctrine/common into several packages.
@greg0ire greg0ire force-pushed the address-persistence-deprecations branch from 0c112bb to 90cbf94 Compare December 19, 2019 18:10
@greg0ire
Copy link
Member Author

I feel stupid, I updated the lock file but not the json manifest 🤦‍♂️ I just pushed with that change.

@alcaeus alcaeus added this to the 2.12.0 milestone Dec 20, 2019
@alcaeus alcaeus self-assigned this Dec 20, 2019
@alcaeus
Copy link
Member

alcaeus commented Dec 20, 2019

Note: I'd like to hold off on merging this as we've seen build failures downstream after merging down changes in doctrine/persistence. I'd like to avoid this over the holidays to give people time to unwind.

@Ocramius Ocramius modified the milestones: 2.12.0, 2.13.0 Jan 10, 2020
@greg0ire greg0ire merged commit 9a9305b into doctrine:master Jan 13, 2020
@greg0ire greg0ire deleted the address-persistence-deprecations branch January 13, 2020 17:55
@doctrinebot doctrinebot mentioned this pull request May 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcaeus alcaeus alcaeus approved these changes

Assignees

@alcaeus alcaeus

Labels
None yet
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@greg0ire @alcaeus @Ocramius