-
-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Psalm #920
Add Psalm #920
Conversation
I did not spot that phpstan was allowed to fail in #910, maybe we could not find another way? An ignore rule would have been better. I'd fix it but I'm on my phone. |
Phpstan errors are:
I think it's better to fix it in another PR |
Me too FTR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it can be handled in another PR.
Thanks @VincentLanglet ! |
Hi @greg0ire does a 3.1.2 release would be possible ? :) |
Thanks |
No description provided.