Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Psalm #920

Merged
merged 4 commits into from
Jan 28, 2021
Merged

Add Psalm #920

merged 4 commits into from
Jan 28, 2021

Conversation

VincentLanglet
Copy link
Contributor

No description provided.

.github/workflows/static-analysis.yml Outdated Show resolved Hide resolved
.github/workflows/static-analysis.yml Outdated Show resolved Hide resolved
@greg0ire
Copy link
Member

I did not spot that phpstan was allowed to fail in #910, maybe we could not find another way? An ignore rule would have been better. I'd fix it but I'm on my phone.

@VincentLanglet
Copy link
Contributor Author

I did not spot that phpstan was allowed to fail in #910, maybe we could not find another way? An ignore rule would have been better. I'd fix it but I'm on my phone.

Phpstan errors are:

 ------ --------------------------------------------------------------------
  Line   lib/Doctrine/Common/Proxy/ProxyGenerator.php
 ------ --------------------------------------------------------------------
  1119   Class ReflectionUnionType not found.
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
  1124   Call to method getTypes() on an unknown class ReflectionUnionType.
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
 ------ --------------------------------------------------------------------

 ------ --------------------------------------------------------------------
  Line   tests/Doctrine/Tests/Common/Proxy/ProxyMagicMethodsTest.php
 ------ --------------------------------------------------------------------
  417    Class Doctrine\Tests\Common\Proxy\MagicIssetClassWithInteger not
         found.
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
 ------ --------------------------------------------------------------------

I think it's better to fix it in another PR

@greg0ire
Copy link
Member

Me too FTR

Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it can be handled in another PR.

@greg0ire greg0ire merged commit 5d7628e into doctrine:3.1.x Jan 28, 2021
@greg0ire
Copy link
Member

Thanks @VincentLanglet !

@greg0ire greg0ire added this to the 3.1.2 milestone Jan 28, 2021
@VincentLanglet VincentLanglet deleted the psalm branch January 28, 2021 21:35
@VincentLanglet
Copy link
Contributor Author

Hi @greg0ire does a 3.1.2 release would be possible ? :)

@greg0ire
Copy link
Member

greg0ire commented Apr 1, 2021

Hi! Sure! https://github.com/doctrine/common/releases/tag/3.1.2

@VincentLanglet
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants