Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reference to version file #973

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Remove reference to version file #973

merged 1 commit into from
Aug 23, 2022

Conversation

greg0ire
Copy link
Member

@greg0ire greg0ire commented Aug 23, 2022 •
edited
Loading

It has been removed in #893

@greg0ire greg0ire requested a review from malarzm August 23, 2022 17:39
@greg0ire greg0ire mentioned this pull request Aug 23, 2022
Merged
@greg0ire greg0ire merged commit 8f61deb into doctrine:3.4.x Aug 23, 2022
@greg0ire greg0ire deleted the remove-reference-to-version branch August 23, 2022 17:49
@stof
Copy link
Member

stof commented Aug 23, 2022

make-release in the ant config file (build.xml) was relying on that version file. I think the ant tooling should be removed entirely.

@malarzm malarzm mentioned this pull request Aug 23, 2022
Merged
@malarzm malarzm added this to the 3.4.0 milestone Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof approved these changes

@malarzm malarzm Awaiting requested review from malarzm

Assignees
No one assigned
Labels
Internal
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@greg0ire @stof @malarzm