Remove useless ignore rules #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
stof
reviewed
Aug 23, 2022
psalm.xml
Outdated
| <file name="lib/Doctrine/Common/Proxy/ProxyGenerator.php" /> | ||
| <file name="tests/Doctrine/Tests/Common/Proxy/ProxyGeneratorTest.php" /> | ||
| <directory name="vendor" /> |
There was a problem hiding this comment.
this ignore rule is also useless AFAICT
greg0ire
force-pushed
the
remove-useless-rule
branch
from
ef55cf7
to
bf5c816
Compare
The referenced issue is fixed, but the fix is not released yet. However, since the "tests" directory is not currently analyzed, the ignore rule is useless. Also, the rule about ignoring the vendor directory is useless.
greg0ire
force-pushed
the
remove-useless-rule
branch
from
bf5c816
to
de40037
Compare
SenseException
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The referenced issue is fixed, but the fix is not released yet. However,
since the "tests" directory is not currently analyzed, the ignore rule
is useless.
Also, the rule about ignoring the vendor directory is useless.