Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use var_export for scalar default values #989

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

malarzm
Copy link
Member

@malarzm malarzm commented Sep 27, 2022

This PR will be good enough to cut a 3.4.2 release. It will:

It is worth mentioning that we will NOT support correctly double-quoted strings in complex default values until a fix in PHP is present (or a workaround is found). Given people never really had a chance to start using such values, I believe this is OK.

@ampaze @Lustmored may I ask you to test your apps with this PR instead of released 3.4.1?

@malarzm malarzm added the Bug label Sep 27, 2022
@malarzm malarzm added this to the 3.4.2 milestone Sep 27, 2022
@ampaze
Copy link

ampaze commented Sep 28, 2022

@malarzm PR works for me.

@Lustmored
Copy link

@malarzm it also works for me. Good job finding the fix so quickly, thank you!

@malarzm malarzm merged commit 609c3a7 into 3.4.x Sep 28, 2022
@malarzm malarzm deleted the var-export-for-scalar-defaults branch September 28, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ProxyGenerator turns double quoted default values into single quoted default values
4 participants