Deprecate callable loggers #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
deprecate/callable-logger
branch
from
8be6255
to
e3d892c
Compare
greg0ire
reviewed
Dec 18, 2023
Merged
derrabus
force-pushed
the
deprecate/callable-logger
branch
from
e3d892c
to
30ede5e
Compare
|
cc @GromNaN |
greg0ire
reviewed
Dec 18, 2023
GromNaN
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
LGTM.
The command doctrine:fixtures:load will need an update to inject a Symfony\Component\Console\Logger\ConsoleLogger instead. The output will become more verbose.
derrabus
force-pushed
the
deprecate/callable-logger
branch
from
30ede5e
to
49595b0
Compare
derrabus
force-pushed
the
deprecate/callable-logger
branch
from
49595b0
to
675a228
Compare
greg0ire
approved these changes
Mar 8, 2024
derrabus
added a commit
to derrabus/data-fixtures
that referenced
this pull request
Mar 8, 2024
* 1.8.x: Deprecate callable loggers (doctrine#462)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not invent our own contract for logging. There's PSR-3 for that.
This PR proposes to deprecate passing a callable to
AbstractExecutor::setLogger()in favor of a PSR-3 logger.I've also deprecated the public
AbstractExecutor::log()method because I believe that the executor should not act as a logger.Note that logging was not covered by tests at all, so the large part of this PR was actually adding tests. 🙈
See #455 (comment) for a discussion.