Backport tests for strict return types #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SenseException
approved these changes
Dec 19, 2023
derrabus
approved these changes
Dec 19, 2023
derrabus
added a commit
to derrabus/data-fixtures
that referenced
this pull request
Mar 8, 2024
* 1.8.x: Adjust PHPStan settings for ORM 3 (doctrine#467) Add tests (doctrine#465) Backport tests for strict return types (doctrine#463)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to add return types in #459, some tests needs to be updated.
I have a partial understanding of how
ReferenceRepositoryworks, with the metadata system.The
setReferencemethod callsgetRealClass, which required$metadata->getName(). Which is casted to an empty string when the mock isn't defined for this method call.