TypeRegistry registry constructor must check for duplicate instances

doctrine · Jul 1, 2023 · d3d11b4 · d3d11b4
1 parent 90469f5
commit d3d11b4
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/Types/TypeRegistry.php b/src/Types/TypeRegistry.php
@@ -21,7 +21,10 @@ final class TypeRegistry
     /** @param array<string, Type> $instances */
     public function __construct(array $instances = [])
     {
-        $this->instances = $instances;
+        $this->instances = [];
+        foreach ($instances as $name => $type) {
+            $this->register($name, $type);
+        }
     }
 
     /**

diff --git a/tests/Types/TypeRegistryTest.php b/tests/Types/TypeRegistryTest.php
@@ -99,6 +99,16 @@ public function testRegisterWithAlreadyRegisteredInstance(): void
         $this->registry->register('other', $newType);
     }
 
+    public function testConstructorWithDuplicateInstance(): void
+    {
+        $newType = new TextType();
+
+        new TypeRegistry(['a' => $newType]);
+
+        $this->expectException(Exception::class);
+        new TypeRegistry(['a' => $newType, 'b' => $newType]);
+    }
+
     public function testOverride(): void
     {
         $baseType     = new TextType();