-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URL-decode URL-style DSN #2504
URL-decode URL-style DSN #2504
Conversation
@Ocramius this looks like a reasonable improvement. The BC question arises of course, especially significant for passwords IMO. What do you think? Shall we accept the slight BC and target this patch for |
This is sane, and can be landed in @c960657 can you add notes for how an upgrade would be performed, and what the BC break for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes as per #2504 (comment)
@c960657 also an entry about URL econding/deconding should make its way into the DBAL documentation. |
d788294
to
7bc59d4
Compare
7bc59d4
to
cdeb9e8
Compare
I have added a test and some upgrade information. |
@c960657 awesome, thanks! |
The URL-style DSN does not support escaping, so if the username/password/database name contains certain characters, the connection options simply cannot be represented this way.
This patch URL-decodes the different parts. It introduces a small BC break for usernames/passwords/database names containing the character
%
.