Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document alternative to Type::getName #6077

Merged
merged 2 commits into from
Jun 29, 2023
Merged

Conversation

Tofandel
Copy link
Contributor

@Tofandel Tofandel commented Jun 28, 2023

Q A
Type Improvement
Fixed issues #6076

Summary

Simply document the deprecation with an alternative and fix a typo

greg0ire
greg0ire previously approved these changes Jun 28, 2023
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least ✅ after you fix the line length of the phpdoc

src/Types/Type.php Outdated Show resolved Hide resolved
Co-authored-by: Alexander M. Turek <me@derrabus.de>
@greg0ire greg0ire dismissed SenseException’s stale review June 29, 2023 10:28

the requested changes have been done

@greg0ire greg0ire merged commit 90469f5 into doctrine:3.6.x Jun 29, 2023
@greg0ire greg0ire added this to the 3.6.5 milestone Jun 29, 2023
derrabus added a commit to derrabus/dbal that referenced this pull request Jul 15, 2023
* 3.7.x:
  Optimize TypeRegistry::lookupName() from O(N) to O(1) (doctrine#6082)
  Add documentation for doctrine#6044 (doctrine#6069)
  Use triggerIfCalledFromOutside in listTableDetails
  Document alternative to Type::getName (doctrine#6077)
derrabus added a commit to derrabus/dbal that referenced this pull request Jul 15, 2023
* 3.7.x:
  Optimize TypeRegistry::lookupName() from O(N) to O(1) (doctrine#6082)
  Add documentation for doctrine#6044 (doctrine#6069)
  Use triggerIfCalledFromOutside in listTableDetails
  Document alternative to Type::getName (doctrine#6077)
derrabus added a commit to derrabus/dbal that referenced this pull request Jul 24, 2023
* 3.7.x:
  Avoid self deprecation about listTableColumn (doctrine#6108)
  Fix blob binding overwrite on DB2 (doctrine#6093)
  Optimize TypeRegistry::lookupName() from O(N) to O(1) (doctrine#6082)
  Add documentation for doctrine#6044 (doctrine#6069)
  Use triggerIfCalledFromOutside in listTableDetails
  Document alternative to Type::getName (doctrine#6077)
cgknx pushed a commit to cgknx/dbal that referenced this pull request Aug 30, 2023
Co-authored-by: Alexander M. Turek <me@derrabus.de>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants