Run risky code in finally block #6543
Merged
+30
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
approved these changes
Oct 11, 2024
derrabus
approved these changes
Oct 11, 2024
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Oct 11, 2024
* 3.9.x: Run risky code in finally block (doctrine#6543)
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Oct 11, 2024
* 3.9.x: Run risky code in finally block (doctrine#6543)
This was referenced Oct 12, 2024
derrabus
added a commit
that referenced
this pull request
Oct 12, 2024
* 4.2.x: Run risky code in finally block (#6543)
derrabus
added a commit
that referenced
this pull request
Oct 12, 2024
* 4.3.x: Use child class as return type Run risky code in finally block (#6543) Fix backwards compatibility of constructors Remove unused variable Fix test Fix CI Add documentation Pass the config to SchemaManager::createComparator() Use setter method instead of config parameter Make column and index renaming configurable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Let's do the same thing as for ORM in doctrine/orm#11646
This somehow solves issue we tried to resolve in #4846 by providing original exception in Previous.