Support Symfony 7 by adding return types conditionally #10919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any chance of getting this into the 2.15.x branch? Our app's test suite has over 7000 tests and hundreds if not thousands of them started failing after the recent UoW commit order changes that were made in the 2.16 release. Fixing all of that is gonna be a huge task and if this only gets merged into 2.17 it's effectively gonna prevent us from updating to Symfony 7 for a long while. |
|
No, we don't maintain 2.15.x anymore. If you want to stay on 2.15, you'll have to fork that branch eventually anyway. |
greg0ire
approved these changes
Aug 24, 2023
derrabus
added a commit
to doctrine/dbal
that referenced
this pull request
Aug 24, 2023
cgknx
pushed a commit
to cgknx/dbal
that referenced
this pull request
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symfony 7 will add more return types to the console component. This PR uses conditional traits to add the necessary return types if they're present upstream. This way, we won't break downstream projects that override our commands unless those projects upgrade to Symfony 7 themselves.