Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed stdout documentation to detail the 's' paramater #39

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Changed stdout documentation to detail the 's' paramater #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Changed stdout documentation to detail the 's' paramater
  • Loading branch information
@tomkadwill
tomkadwill committed Jul 31, 2014
commit bfdb40cb0df596ffa64da2267c097ba2480b78e1
6 changes: 3 additions & 3 deletions lib/debug.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -902,9 +902,9 @@ def stdout
@stdout
end

# Sets the IO used as stdout. Defaults to STDOUT
def stdout=(s)
@stdout = s
# Sets the IO used as +stdout+. Defaults to STDOUT
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stdout is more readable. wdyt about changing this to

# Sets the IO used as +stdout+. Defaults to STDOUT
      def stdout=(stdout)
        @stdout = stdout
      end

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vipulnsward Yes I think that does look better. I was thinking about that but didn't know whether it was called s for a reason. I've updated my PR to reflect the change that you suggested.

def stdout=(stdout)
@stdout = stdout
end

# Returns the display expression list
Expand Down