Document that Timeout.timeout and Thread.raise are unsafe operations #60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in this blog post, Timeout is a dangerous method that can result in really nasty & subtle bugs. Ruby's current documentation says only:
which does not indicate that one should be very careful when attempting to use it.
Java documents extensively that using
Thread.stop
is discouraged, is both in the javadocs for thread.stop and on this page explaining why the method was deprecatedHere's the beginning of the Java documentation for
Thread.stop
:I'd like to propose that Ruby include a similar warning. this is my first attempt at contributing to Ruby (documentation or otherwise), so very happy to make edits and explain more clearly.