Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added onSnapToItem trigger for didMount and update index changing logic #524

Open
wants to merge 1 commit into
base: v3.x.x
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Carousel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,11 @@ const Carousel = React.forwardRef<ICarouselInstance, TCarouselProps<any>>(
[getCurrentIndex, next, prev, scrollTo],
);

React.useEffect(() => {
// add onSnapToItem call when component is first mounted
onSnapToItem?.(defaultIndex || 0);
}, []);

const visibleRanges = useVisibleRanges({
total: dataLength,
viewSize: size,
Expand Down
3 changes: 3 additions & 0 deletions src/hooks/useOnProgressChange.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ export function useOnProgressChange(
if (value > 0)
absoluteProgress = rawDataLength - absoluteProgress;

if (absoluteProgress > (rawDataLength - 0.5)) // threshold set as half of the size
absoluteProgress = 0;

if (onProgressChange)
runOnJS(onProgressChange)(value, absoluteProgress);
},
Expand Down