Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter illegal header fields #2842

Merged
merged 10 commits into from
Apr 29, 2024
Merged

Filter illegal header fields #2842

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9765671
Filter illegal header fields
keahpeters Apr 28, 2024
2210c9b
Cleanup
keahpeters Apr 28, 2024
e021c47
Cleanup
keahpeters Apr 28, 2024
b779e89
Improve unit tests
keahpeters Apr 28, 2024
15440ea
Cleanup
keahpeters Apr 29, 2024
35c3437
Merge branch 'master' into filter-illegal-header-fields
keahpeters Apr 29, 2024
5f84dc1
Add missing using
keahpeters Apr 29, 2024
3a21817
Code review changes
keahpeters Apr 29, 2024
40cb61f
Fix failing unit tests
keahpeters Apr 29, 2024
a92859b
Cleanup
keahpeters Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Cleanup
  • Loading branch information
@keahpeters
keahpeters committed Apr 28, 2024
commit e021c47ff61e1eac5de1f8eecd165f068e2ef423
2 changes: 1 addition & 1 deletion test/Swashbuckle.AspNetCore.SwaggerGen.Test/Fixtures/FakeController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public void ActionWithIntParameterWithRequiredAttribute([Required]int param)
public void ActionWithIntParameterWithSwaggerIgnoreAttribute([SwaggerIgnore] int param)
{ }

public void ActionWithAcceptFromHeaderParameter([FromHeader(Name = "Accept")] int accept)
public void ActionWithAcceptFromHeaderParameter([FromHeader] string accept)
{ }

public void ActionWithObjectParameter(XmlAnnotatedType param)
Expand Down
8 changes: 5 additions & 3 deletions test/Swashbuckle.AspNetCore.SwaggerGen.Test/SwaggerGenerator/SwaggerGeneratorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
using Swashbuckle.AspNetCore.TestSupport;
using Xunit;
using System.Threading.Tasks;
using System.Reflection.Metadata;

namespace Swashbuckle.AspNetCore.SwaggerGen.Test
{
Expand Down Expand Up @@ -536,6 +537,7 @@ public void GetSwagger_IgnoresParameters_IfActionParameterIsIllegalHeaderParamet
[Fact]
public void GetSwagger_GenerateParametersSchemas_IfActionParameterIsIllegalHeaderParameterWithProvidedOpenApiOperation()
{
var parameter = typeof(FakeController).GetMethod(nameof(FakeController.ActionWithAcceptFromHeaderParameter)).GetParameters()[0];
var methodInfo = typeof(FakeController).GetMethod(nameof(FakeController.ActionWithAcceptFromHeaderParameter));
var actionDescriptor = new ActionDescriptor
{
Expand All @@ -548,7 +550,7 @@ public void GetSwagger_GenerateParametersSchemas_IfActionParameterIsIllegalHeade
{
new OpenApiParameter
{
Name = "accept"
Name = parameter.Name
}
}
}
Expand All @@ -571,9 +573,9 @@ public void GetSwagger_GenerateParametersSchemas_IfActionParameterIsIllegalHeade
{
new ApiParameterDescription
{
Name = "accept",
Name = parameter.Name,
Source = BindingSource.Header,
ModelMetadata = ModelMetadataFactory.CreateForType(typeof(string))
ModelMetadata = ModelMetadataFactory.CreateForParameter(parameter)
}
}),
}
Expand Down