Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix loader logs #114

Merged
merged 2 commits into from
Jun 19, 2020
Merged

Bugfix loader logs #114

merged 2 commits into from
Jun 19, 2020

Conversation

hugodes
Copy link
Contributor

@hugodes hugodes commented Oct 29, 2019 •
edited
Loading

Fixes #112

@hugodes
Copy link
Contributor Author

hugodes commented Oct 29, 2019

Fixes #112

@hugodes hugodes mentioned this pull request Oct 29, 2019
Closed
@leifb
Copy link

leifb commented Nov 28, 2019

Thanks! I just edited the file manually in my node_modules to get an error message and it's working.

@gambhirpulkit
Copy link

@matmar10 can you please review and merge?

@odub
Copy link

odub commented Apr 30, 2020

I am also experiencing this issue, it'd be great to see this merged!

@glennposadas
Copy link

Can we merge this? @matmar10 @domasx2 ?

For newbies like me, this is how you install the package targeting this commit/branch.

npm i hugodes/sequelize-fixtures#bugfix-loader-logs

@glebsts
Copy link

glebsts commented Jun 19, 2020 •
edited
Loading

Hello? Can you merge it?

@domasx2 domasx2 merged commit a107af5 into domasx2:master Jun 19, 2020
@domasx2
Copy link
Owner

domasx2 commented Jun 19, 2020

Hi, published sequelize-fixtures@1.2.0, thanks a lot for the fix!

@hugodes
Copy link
Contributor Author

hugodes commented Jun 19, 2020

You're welcome, thanks for merging and publishing !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaisfaria thaisfaria thaisfaria approved these changes

@matmar10 matmar10 Awaiting requested review from matmar10

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read property 'warn' of undefined
8 participants
@hugodes @leifb @gambhirpulkit @odub @glennposadas @glebsts @domasx2 @thaisfaria