Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v115.0 #21

Closed
wants to merge 4,050 commits into from
Closed

v115.0 #21

wants to merge 4,050 commits into from

Conversation

dothq-robot
Copy link

Firefox v115.0

Merge in changes from upstream (v115.0)

Checklist

  • Changes have been reviewed
  • If necessary, any changes downstream (dothq/browser-desktop) have been made
  • Upstream with Dot Browser mounted can be built
  • REVISION file is ready to be updated

Rob--W and others added 30 commits June 5, 2023 10:23
@Rob--W
Bug 1830814 - Migrate remaining extension jsm files to ESM r=geckovie…
9dd7fe1 
…w-reviewers,Standard8,m_kato, a=dmeehan

Differential Revision: https://phabricator.services.mozilla.com/D179890
Bug 1800296 - fix test_autocomplete_tab_between_fields.html intermitt…
a1c60a6 
…ent - r=credential-management-reviewers,sgalich,dimi a=test-only

and enable the test again

Differential Revision: https://phabricator.services.mozilla.com/D179798
@glandium
Bug 1836723 - Link against ntdll for rustc 1.70. r=firefox-build-syst…
48f82ea 
…em-reviewers,ahochheiden, a=dmeehan

Building with rustc 1.70 adds a dependency to the ntdll library through
libstd using NtCreateFile/NtWriteFile (it previously picked the symbols
at runtime).

Differential Revision: https://phabricator.services.mozilla.com/D180011
@glandium
Bug 1836883. Avoid passing ref function arguments to Rc::from_raw. r=…
905d525 
…eemeli a=pascalc

It is unfortunately undefined behavior and leads to problems with LLVM
16.

Differential Revision: https://phabricator.services.mozilla.com/D180061
@emilio
Bug 1836928 - Change some references to raw pointers in some FFI func…
1a4070c 
…tions. r=glandium, a=dmeehan

Even tho rust-lang/rust#112337 is IMO a rust
bug, it's easy to work around in our code and it doesn't really affect
expressiveness.

Differential Revision: https://phabricator.services.mozilla.com/D180065
@0c0w3
Bug 1836585 - Change the "Top pick" label to "Firefox extension" for …
be34521 
…addon suggestions. r=daisuke,fluent-reviewers,flod, a=dmeehan, l10n=flod

This uses the new label but only when the addon suggestion is shown as a best
match. Otherwise the suggestion will be shown in the usual Firefox Suggest group
so it should use that label.

I chose `-brand-product-name`, which is always "Firefox" even on Nightly. I
don't think it makes sense to talk about "Nightly extensions".

Differential Revision: https://phabricator.services.mozilla.com/D179868
@0c0w3
Bug 1836582 - Update the matching behavior of addon suggestions. r=da…
5dd3238 
…isuke, a=dmeehan

This implements the new required matching behavior, which isn't based on min
keyword length anymore. This is how it works:

* Use the full keywords in remote settings to generate keywords that contain the
  first word plus each possible substring after the first word. For example if a
  full keyword is "video download", then generate these keywords: "video",
  "video ", "video d", "video do", etc. If a full keyword is only one word, then
  use it as is. The keywords never change even when the user clicks "Show less
  frequently". This is implemented in `onRemoteSettingsSync()`, and I modified
  `SuggestionsMap.add()` to make it easy to generate new keywords from the
  strings in `suggestion.keywords`.
* Keep track of the number of times the user clicked "Show less frequently" in
  `showLessFrequentlyCount`.
* When a suggestion is fetched from the suggestions map, filter it out if the
  search string isn't long enough given the `showLessFrequentlyCount`. This is
  done in `makeResult()`.

Other changes:

* I made some of the private properties in `AddonSuggestions` public so that the
  xpcshell test can easily use them. I think it's OK for them to be public.
* Added `show_less_frequently_cap` to the RS config object so that we can
  specify a cap in RS as well as Nimbus.
* mv'ed test_quicksuggest_addResults.js to test_suggestionsMap.js, since I
  modified this file. I should have done that back when I replaced `addResults()`
  with `SuggestionsMap`.
* Fixed a bug in `SuggestionsMap.add()` where the same suggestion could be added
  multiple times to the array stored in the map, if it had duplicate keywords.

Differential Revision: https://phabricator.services.mozilla.com/D179867
@jensstutte
Bug 1833790 - Ignore StrongWorkerRef callback if mWorkerRef is alread…
4929e1c 
…y cleared. r=dom-worker-reviewers,asuth, a=dmeehan

Differential Revision: https://phabricator.services.mozilla.com/D180072
@Rob--W
Bug 1835790 - Drop UTF-8 BOM when reading native manifests r=extensio…
431aafc 
…n-reviewers,rpl, a=dmeehan

Differential Revision: https://phabricator.services.mozilla.com/D180103
@glandium
Bug 1836883. Avoid passing ref function arguments to Rc::from_raw. r=…
61bc19a 
…eemeli, a=dmeehan

It is unfortunately undefined behavior and leads to problems with LLVM
16.

Differential Revision: https://phabricator.services.mozilla.com/D180061
@Rob--W
Bug 1835790 - Drop UTF-8 BOM when reading native manifests r=extensio…
2be4fd1 
…n-reviewers,rpl a=pascalc

Differential Revision: https://phabricator.services.mozilla.com/D180103
@janvarga
Bug 1825552 - Let existing operation to finish before closing the str…
8399f46 
…eam; r=dom-storage-reviewers,jari, a=dmeehan

Differential Revision: https://phabricator.services.mozilla.com/D178017
@janvarga
Bug 1825552 - Avoid the new/delete pattern; r=dom-storage-reviewers,j…
f847a30 
…ari, a=dmeehan

Differential Revision: https://phabricator.services.mozilla.com/D179559
@jonco3
Bug 1835710 - Cancel off-thread JIT compilation before changing nurse…
32918e3 
…ry allocation flags r=jandem, a=dmeehan

This calls CancelOffThreadIonCompile before changing the nursery allocation
flags to avoid the race condition with off-thread compilation reading these
flags.

Nursery::discardJitCodeForZone is renamed to make it clear that it also sets
JIT flags.

Differential Revision: https://phabricator.services.mozilla.com/D179542
@mystor
Bug 1826206 - Require nsISerialEventTarget for RetargetDeliveryTo, r=…
94ccd62 
…necko-reviewers,valentin, a=dmeehan

This avoids potential issues where multiple OnDataAvailable callbacks or
similar could theoretically be called concurrently on different
StreamTransportService threads when targeting the STS - these cases will
now target a TaskQueue on the STS instead, structurally ensuring serial
execution.

Differential Revision: https://phabricator.services.mozilla.com/D179984
no bug - Bumping Firefox l10n changesets r=release a=l10n-bump
5531bf4 
cy -> 2d6b7baafd10924112c0d5817b1c7fff4c403e03
de -> ec98fb74db0a484dd0a4b77cfe133805ae08888a
es-AR -> 0fc410704d3d48eae1d6ace08c3eaa32f20497a9
fr -> 913339aa9121f1dbcb6f78c8e6e5676f68a195ff
he -> e8f376a3164397890841084dec220f3e267bca35
it -> 8be5b6bff2b29e0447a486e9d2ceef962142e8d7
ka -> 7b6a492d07042210acd107d247fad702c6ceec86
ko -> c6722f9c30add583ffd691227a8d4d99f2483849
oc -> 01610a448076c31113dbfd427a00f9c79aa32f1d
ru -> a6c8cb735bc5bf3df71dc2cf9514cce5f9304b25
sk -> 9b1ba3c0d78b76024aae4e7aa48cfadacde32ae1
tr -> 8411f3a86b8b608a885ee02d4e65c021081ae358
zh-CN -> 891e4ba6e0986c3a00ca439f422288e57f5ebe34
@daleharvey
Bug 1834060 - Ensure urlbar weather view does not wrap on small width…
96a015f 
…s. r=dao, a=dmeehan

Differential Revision: https://phabricator.services.mozilla.com/D180021
@mozkeeler
Bug 1834862 - implement nsICryptoHash in rust r=jschanck,supply-chain…
27c7992 
…-reviewers, a=dmeehan

Differential Revision: https://phabricator.services.mozilla.com/D179727
@glandium
Bug 1837086 - Properly pass -pie when linking. r=firefox-build-system…
ae34527 
…-reviewers,sergesanspaille, a=dmeehan

There was a syntax error introduced in bug 1796380 that removed the flag
entirely. In practice, it didn't make a difference for us because clang
now defaults to PIE, but it can make a difference in environments where
the compiler is not using such a default.

However, on both Darwin and WASI, clang complains the flag is unused, so
we have to do something about it.

Differential Revision: https://phabricator.services.mozilla.com/D180279
@glandium
Bug 1837122 - Fix typo introduced in bug 1834446. r=firefox-build-sys…
26fe640 
…tem-reviewers,sergesanspaille, a=dmeehan

Differential Revision: https://phabricator.services.mozilla.com/D180174
Bug 1833987 - fix more intermittent tests - r=credential-management-r…
32a256e 
…eviewers,dimi a=test-only DONTBUILD

Differential Revision: https://phabricator.services.mozilla.com/D179826
No Bug, mozilla-beta repo-update HSTS HPKP remote-settings tld-suffix…
065169c 
…es - a=repo-update, r=dmeehan

Differential Revision: https://phabricator.services.mozilla.com/D180316
@Rob--W
Bug 1837185 - Correct loader for extension imports in WebExtension de…
0182536 
…scriptor +tests r=rpl,devtools-reviewers,jdescottes, a=dmeehan

The WebExtensionDescriptorActor loaded extension modules with the
dedicated devtools loader, which returns a different instance than
the real module in the browser. Besides the code not being designed to
be loaded twice in the same browser instance, this has the following
devtools-protocol-observable consequences:

- Uninitialized AddonManager -> Unable to detect addon updates/uninstalls.
- Detached ExtensionParent -> Unable to observe the actual extension,
  including not seeing extension state such as warnings.

Differential Revision: https://phabricator.services.mozilla.com/D180292
@Rob--W
Bug 1837185 - Correct remaining extension imports in devtools modules…
5facfc0 
… r=rpl,devtools-reviewers,jdescottes, a=dmeehan

Extension modules are singletons and must never be loaded through the
dedicated DevTools loader. This happens when --start-debugger-server is
used.

These files in question are primarily designed to support the Firefox
devtools, so I haven't created separate unit tests for these cases.
The kind of problem associated with this import pattern has been covered
by other patches in this bug.

Differential Revision: https://phabricator.services.mozilla.com/D180293
@ScottDowne
Bug 1832165 - Pocket newtab international expansion turn off onboardi…
7781afc 
…ng dialog r=gvn, a=dmeehan

Differential Revision: https://phabricator.services.mozilla.com/D180334
@mgaudet
Bug 1833315 - Pass JSOp along rather than recomputing r=iain, a=dmeehan
8ddcfb0 
The goal of this patch is to avoid the bad store forwarding on
some Samsung phones

Differential Revision: https://phabricator.services.mozilla.com/D180268
@valenting
Bug 1836475 - Perma Late Beta test_interfaces_secureContext.html | ap…
71de9f8 
…plicationCache should be defined r=emilio, a=test-only

Differential Revision: https://phabricator.services.mozilla.com/D180176
@anna-yeddi
Bug 1833988 - Add waitForMutationCondition to browser_datetime_datepi…
fc9a3e6 
…cker_prev_next_month.js test. r=Jamie,mconley, a=test-only

Moving a Backspace key event and add `ContentTaskUtils.waitForMutationCondition` for `input.value` to ensure the environment for previously buggy behavior (bug 1817785) is created so the proper datepicker keyboard behavior is tested.

Differential Revision: https://phabricator.services.mozilla.com/D180157
@janvarga
Bug 1837201 - Ignore unsupported origin directories during various op…
d9e487a 
…erations; r=dom-storage-reviewers,jstutte,asuth, a=dmeehan

Differential Revision: https://phabricator.services.mozilla.com/D180349
no bug - Bumping Firefox l10n changesets r=release a=l10n-bump
631f3f9 
ach -> f76c6bd4d425f9b96ea490e5a34784288b8d019e
an -> 79a6b3eda1ad7cbbb7c0ece553c4bc9c56d44e99
ar -> ee2daa0aacc21badf832068399d929442b82f527
ast -> 164f6f0915b6461cc4ccf333f8b8818e0bbbc09c
az -> c0d195f9cc2630d4cf765a8d2df8ae21d41cbb51
be -> 4349f86ff84ac0e6aef9d830c517f739295d5fb7
bg -> 8e7796a1f2c2bd92c0aac75968f269206b6426de
bn -> 2c3c5b00a19370fb835de9a25f5798bd783541fa
br -> 782ed03b99b43279589e0c9cbb6767206e24fd8c
bs -> 8f39c650de01eb7fa87c0ae3b95fe511bf2cc3a3
ca -> 4259c649c0aa79fbf584a6f615f869cb4bc7b43d
ca-valencia -> 625f0a4536cb681bcb90168bd306c9e1cbb07c41
cak -> 68bb09347bffd2d1293a73dd9ce2a78d98976713
cs -> 3112c710376f2303ec58ba2143cf0ec5032cc580
cy -> f1eab19ce033c96c1ef89b39ea14c6664ef3906e
da -> cb0da11a0f17b2f1506292766c04f3f864a0a2e0
de -> 19c6b68c5e2ceb5d52eb68b44fe38f2c4ec7894a
dsb -> 68fd28f3b636075cf97d76f6683bf805684deeb6
el -> ba88bbfbbfac68580df56847d0b258f022dbaedb
en-CA -> bf3dca6c3d0cc2ccbe7350546f7dbe32147a5d53
en-GB -> 28311aae01e9f1d27f3e48babb0814a8252e02fb
eo -> 1f5d13d3d701de8230de007e5af4fd07e4cf5631
es-AR -> 042a5acd1d51a62427162711b5a271655835d1ce
es-CL -> 4d476f5c4f10101df802bbc7cf4f59a81f3933f0
es-ES -> 9b8c7e0c39f2b6d375fcb68c930924197c5865fd
es-MX -> 16dd9a6740878c11511c47aeaf1d4006e2736463
et -> 0d0227b5d7029c9c663afda6f0723dd797dfc5cf
eu -> 64b0ab7ddb717e8c4758ee093177457f57c81986
fa -> b3dfe954ae0218b09b8dd3ad87a02f83c2709761
ff -> 8cc7ee6037b6615405939d79807fd5d3daaf9b7c
fi -> d58e42845a3103732999dabe66eeb376d70e1fed
fr -> afca515181dcea9165669f66ed13153d615b5308
fur -> 9e63a153be53ed13ed6fe052beeb1f6d53b8200b
fy-NL -> 1eec52a377256c08e8796ff31d4e8876f9c05250
gd -> d4ac819a33c1919073432d1941518429e0a41b41
gl -> 679a7a969f36c74703952ae231cd49d3ae7b2dbc
gn -> 69058b29e88d7e1dba536ee235d75009a1527688
gu-IN -> dc402d4eb962539d35e4aa0214531ed831119051
he -> f84e7fb19b9683dc458be067a9b50b61fc576f19
hi-IN -> 78807a134bb619172ad960ad837b743eac3f3cca
hr -> 7c4440400dcd39cd8a6917ed57f79877e3860117
hsb -> 7fd79616455e4edb71776b39a4bbf2b76f375ec2
hu -> e14bc1d3354173cee67d30fcb5d18f7a20719335
hy-AM -> 9f63da68e9e891284d56f7c7e6d49850da8a39dc
ia -> 1cc67cc56a7d939872c199276f554c37c2cc238a
id -> fca3933c4dbff50ae9d59e4602eb0c6829a51df4
is -> 9c46a74e8f72757a196d922148a493d187a1d92d
it -> 78c82eabb48000dc0cf1b283f2c8dc43a712c1c5
ja -> 5763ff4ab538ca56e7c1a712144e1eb1506ff7d2
ja-JP-mac -> 55f30933875bb3a0a451caea5c3af9ce5a525993
ka -> fe351c2caeff69f240af15b231d6e11f43cfec3e
kab -> 9b14787ff9d1d7b0774a8c4c2dfa9fc132e301c0
kk -> 35ef39b6f194c28295b550368064840d48306839
ko -> af56f4d727e2ef817bf95a671d07bfc94686edae
lij -> 068a308fdf5bf968ba8bebc535363235e74750b4
lt -> 2fee3e490593a78a8ef42b3c8ea05d9d3aa14099
lv -> e4740c02ae6601d8bf25302e6416c3238215931a
mr -> 2adf095e284a4fa43c1ba8e9602ffa784bc20b24
ms -> 3cf7ab54efacfa90896e00aec5f431b75f8399c4
nb-NO -> 32528f47057102fc420f87f64f4842fe97f594f1
nl -> 137fe0308802a36b9cad9b28f274b50d700c3d5e
nn-NO -> 479adab9c493f125ec99c036f30f1f64f42aac70
oc -> 8502cc5292a62e0f43e509485313a9cd7b6cc6f9
pa-IN -> 7e698dac192efad2d2c4010818cdad5e6ad50f60
pl -> 552bd42fbd903f1a2bfb6b421ab690a6087133fa
pt-BR -> 23ef093e5f29968822f720a185c386d52e3ae798
pt-PT -> 3643aa753e66ce09c354f6e31ecc09e2b7d5b250
rm -> 8ac047218c8073537c67ef3b1795a07aeeda51c0
ro -> 502cc0e557abd59c64df8221148af357568aa7ae
ru -> bb1a535edb236ddcd5a1947f545c9747e7a53c02
sc -> ddaddc0948341f965bb0d1f82a6c02baaa70b23a
sco -> f936cd534ea785a5c84861baaea66ca1f6f8ae8f
si -> eee348b298d3490afba03e3658064b39d031850d
sk -> 9a1adf5453284b3f95d716524c95b33acc54191a
sl -> be4227a893e5e9ae4277663e4c4ffc3bf974b98a
sq -> 89de925c7ca4752ee5b542309bde33fb0751573a
sr -> 1b7d4c41cf10ff29aa65e5d86ee8a616c7bab4a7
sv-SE -> ea7de7289560fb44865d9bbd4ed8c6d169969743
szl -> 842d2097e5fd776a64d45ba6c88c5ad3b246a122
te -> 48e5e6e983a64f3306f17155351b2e0b8a566f0a
tg -> 98d3030dc1bbb14cd6e7baf845c7c8b2062cc430
th -> 6dd924b0273b1926788a2818fed308b45ec4b7bb
tl -> 527069ae36bd8cb5374703a5a4306b1e499e4318
tr -> 1af429e2677dbda188d3c2301bc104a6e46355c5
trs -> d09b41aa82e023b6c740b1fddb4fbc2b65972305
uk -> fadee8136105dd7195aa2035b82a84c2b45e78ff
ur -> 1ae1751c720871ebabc7163c3e62bc0058aab5d2
vi -> 162114afd00fa5f60f6239c9ae2a1d03690d5983
zh-CN -> 6de1a7dffcfe75db78828886be32923e90af7aaa
zh-TW -> 18ddf27cb551aa5c57261b4bffea1669d7c6a07a
Glenn Watson and others added 27 commits June 7, 2023 20:16
Bug 1836693 - Fix 9-patch mask rendering for specific ellipse shapes …
869ad98 
…r=gfx-reviewers,nical, a=dmeehan

Differential Revision: https://phabricator.services.mozilla.com/D179905
@artines1
Bug 1839464 - Check storage access in content accessible about pages.…
dd208d4 
… r=bvandersloot,anti-tracking-reviewers, a=dmeehan

Differential Revision: https://phabricator.services.mozilla.com/D181807
No Bug, mozilla-beta repo-update HSTS HPKP remote-settings - a=repo-u…
7ba031a 
…pdate, r=dmeehan

Differential Revision: https://phabricator.services.mozilla.com/D181991
@makotokato
Bug 1832195 - Don't fire full screen request immediately. r=edgar, a=…
6a0d15c 
…dmeehan

Differential Revision: https://phabricator.services.mozilla.com/D180086
@makotokato
Bug 1832195 - Update browser_fullscreen_exit_on_external_protocol.js.…
289e969 
… r=edgar, a=dmeehan

Due to previous fix, I need to update
`browser_fullscreen_exit_on_external_protocol.js` since internal fullscreen
event isn't dispatched before request is canceled.

Also, I add one more test for cancelling fullscreen during transition.

Differential Revision: https://phabricator.services.mozilla.com/D181955
@calixteman
Bug 1839343 - Add a container for Signature with their own canvas r=#…
016a7ad 
…pdfjs-reviewers, a=dmeehan

Differential Revision: https://phabricator.services.mozilla.com/D182005
@mozkeeler
Bug 1834862 - implement nsICryptoHash in rust r=jschanck,supply-chain…
34921ec 
…-reviewers, a=dmeehan

Differential Revision: https://phabricator.services.mozilla.com/D179727
No bug - tagging 035b72e275569245ab5c8844f4ddca8f5ce7da42 with FIREFO…
d295656 
…X_RELEASE_115_BASE a=release DONTBUILD CLOSED TREE
Merge old head via |hg debugsetparents c4ed5781ba9260b6a46b97be4c66f3…
9da8773 
…2a28eea1a6 4d4fa6c989784cadba74fc27f5c2189d912974a9| CLOSED TREE DONTBUILD a=release
Preserve old tags after debusetparents. CLOSED TREE DONTBUILD a=release
5f42f32
No bug - tagging 4d4fa6c989784cadba74fc27f5c2189d912974a9 with FIREFO…
43917cf 
…X_RELEASE_114_END a=release DONTBUILD CLOSED TREE
Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release…
9c13862 
… ba=release
No bug - Tagging 52e1bf38cf66e43d8b27e0d4a127d2b44bc3208c with FIREFO…
e21f806 
…X_115_0_BUILD1 a=release CLOSED TREE DONTBUILD
Bug 1839852 - Allow access to LD_LIBRARY_PATH from Utility process r=…
23787c7 
…gcp, a=dmeehan

Differential Revision: https://phabricator.services.mozilla.com/D181767
@KershawChang
Bug 1840300 - cancel async copy with NS_BASE_STREAM_CLOSED during shu…
c509289 
…tdown, r=necko-reviewers,valentin, a=dmeehan

Differential Revision: https://phabricator.services.mozilla.com/D181986
@jfx2006
Bug 1840457 - Update macos sdk URL. r=firefox-build-system-reviewers,…
07b3861 
…glandium, a=dmeehan

Differential Revision: https://phabricator.services.mozilla.com/D182098
@dshin-moz
Bug 1839550 - Back out increased clamping range. r=dholbert, a=dmeehan
a26aaae 
Was introduced in bug 1831148, regresses the behaviour fixed by
bug 1419225.

Differential Revision: https://phabricator.services.mozilla.com/D182346
Backed out changeset 6e88284903db (bug 1836693) with Bug 1836052 and …
7f341b9 
…Bug 1830588 for causing regressions
Backed out changeset eeba3a3c20a4 (bug 1836052) with Bug 1836693 and …
f9d1267 
…Bug 1830588 for causing regressions
Backed out changeset 928b0d1a27d5 (bug 1830588) with Bug 1836052 and …
cda3124 
…Bug 1836693 for causing regressions
Bug 1839037 - Remove tab manager button opacity to prevent slowdown r…
251e06f 
…=mhowell, a=dmeehan

Differential Revision: https://phabricator.services.mozilla.com/D182267
No Bug, mozilla-release repo-update remote-settings - a=repo-update, …
fdbb859 
…r=dmeehan

Differential Revision: https://phabricator.services.mozilla.com/D182444
No bug - Tagging 1c2603279ac3bf5c442bf416ee7bf6d7d2c20d31 with FIREFO…
eb622f2 
…X_115_0_BUILD2 a=release CLOSED TREE DONTBUILD
No bug - Tagging 1c2603279ac3bf5c442bf416ee7bf6d7d2c20d31 with FIREFO…
abf69b4 
…X_115_0_RELEASE a=release CLOSED TREE DONTBUILD
Automatic version bump CLOSED TREE NO BUG a=release DONTBUILD
37a00d8
@mystor
Bug 1841660 - Fix potential deadlock waiting for StartupCache Threade…
16092eb 
…dPrefetch, r=jesup, a=dmeehan

In a previous change to this logic, we missed a hidden early return in
the `MMAP_FAULT_HANDLER_CATCH()` macro which can early return on both
Linux and Windows. If this is hit, we could end up blocking at various
points waiting for the StartupCache to be prefetched.

This patch changes the logic to notify to happen in a ScopeExit instead,
ensuring that it'll happen on all return paths.

In addition, there was another potential deadlock due to the
ThreadedPrefetch thread acquiring mTableLock. This was fixed by passing
in the pointers in the runnable instead. This should be OK as we are
making sure to block on ThreadedPrefetch before we clear the startup
data already.

Differential Revision: https://phabricator.services.mozilla.com/D182732
@yjugl
Bug 1837242 - Fix the DLL blocklist code for older versions of Window…
686888d 
…s. r=gstoll, a=dmeehan

While fixing a crash in bug 1733532, we accidentally broke the DLL
blocklist on older versions of Windows (Windows 7, some versions
of Windows 10, and possibly Windows 8 and 8.1). This is currently
preventing us from mitigating crashes with third-party injected DLLs, in
particular the crash incident from bug 1837242. Considering the volumes
involved, let's temporarily reintroduce bug 1733532 to ensure everyone
has a working blocklist, and deal with bug 1733532 later.

Differential Revision: https://phabricator.services.mozilla.com/D182917
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kierandrewett kierandrewett Awaiting requested review from kierandrewett

Assignees

@kierandrewett kierandrewett

Labels
None yet
Projects
None yet
Milestone
No milestone