Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set TreatWarningsAsErrors to true #1897

Merged
merged 5 commits into from
Aug 24, 2022
Merged

set TreatWarningsAsErrors to true #1897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d464c96
set TreatWarningsAsErrors to true to ensure that no new warnings are …
adamsitnik Jan 23, 2022
068ed4f
Merge branch 'master' into warningsAsErrors
adamsitnik Jul 15, 2022
f53d99f
Merge branch 'master' into warningsAsErrors
adamsitnik Aug 24, 2022
21836d2
solve the only warning we have
adamsitnik Aug 24, 2022
16f0a71
Merge branch 'master' into warningsAsErrors
adamsitnik Aug 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build/common.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
<UseSharedCompilation>false</UseSharedCompilation>
<SuppressNETCoreSdkPreviewMessage>True</SuppressNETCoreSdkPreviewMessage>
<CodeAnalysisRuleSet>$(MSBuildThisFileDirectory)CodingStyle.ruleset</CodeAnalysisRuleSet>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 2 additions & 0 deletions src/BenchmarkDotNet.Diagnostics.Windows/EtwProfilerConfig.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ public class EtwProfilerConfig
public float CpuSampleIntervalInMilliseconds { get; }

public KernelTraceEventParser.Keywords KernelKeywords { get; }

public KernelTraceEventParser.Keywords KernelStackKeywords { get; }

public IReadOnlyDictionary<HardwareCounter, Func<ProfileSourceInfo, int>> IntervalSelectors { get; }
Expand All @@ -31,6 +32,7 @@ public class EtwProfilerConfig
/// <param name="cpuSampleIntervalInMilliseconds">The rate at which CPU samples are collected. By default this is 1 (once a millisecond per CPU). There is a lower bound on this (typically 0.125 ms)</param>
/// <param name="intervalSelectors">interval per hardware counter, if not provided then default values will be used.</param>
/// <param name="kernelKeywords">kernel session keywords, ImageLoad (for native stack frames) and Profile (for CPU Stacks) are the defaults</param>
/// <param name="kernelStackKeywords">This is passed to TraceEventSession.EnableKernelProvider to enable particular sets of events. See https://docs.microsoft.com/windows/win32/api/evntrace/ns-evntrace-event_trace_properties#members for more information on them.</param>
/// <param name="providers">providers that should be enabled, if not provided then default values will be used</param>
/// <param name="createHeapSession">value indicating whether to create heap session. False by default, used internally by NativeMemoryProfiler.</param>
public EtwProfilerConfig(
Expand Down