Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce async overhead #1968

Closed
wants to merge 22 commits into from
Closed

Reduce async overhead #1968

wants to merge 22 commits into from

Commits on Aug 15, 2022

  1. Added AwaitHelper to properly wait for ValueTasks. 

    Updated BenchmarkType and InProcess toolchains to use AwaitHelper.
    @timcassell
    timcassell committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    e087c6f View commit details
    Browse the repository at this point in the history

  2. Fixed (Value)Task<T> for InProcessEmitToolchain.

    @timcassell
    timcassell committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    8d43431 View commit details
    Browse the repository at this point in the history

  3. Added support for (Value)Task Setup and Cleanup in InProcessEmitToo… 

    …lchain.

Added support for `ValueTask` benchmark in InProcess.NoEmit.
Added tests.
    @timcassell
    timcassell committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    e63ca1e View commit details
    Browse the repository at this point in the history

  4. Add readonly modifier to awaitHelper emit field.

    @timcassell
    timcassell committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    08ef9d9 View commit details
    Browse the repository at this point in the history

  5. Fix ldloc index

    @timcassell
    timcassell committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    f207ba0 View commit details
    Browse the repository at this point in the history

  6. Fixed InProcessBenchmarkEmitsSameIL tests.

    @timcassell
    timcassell committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    c7d0676 View commit details
    Browse the repository at this point in the history

  7. Update Setup/Cleanup IL to match workload.

    @timcassell
    timcassell committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    42ceaee View commit details
    Browse the repository at this point in the history

  8. Fixed (Value)Task<T>-returning Setup/Cleanup methods.

    @timcassell
    timcassell committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    85fa2ef View commit details
    Browse the repository at this point in the history

  9. Fixed naming and CanBeNullAttribute.

    @timcassell
    timcassell committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    7be7819 View commit details
    Browse the repository at this point in the history

  10. Fixed awaiterCompleted check.

    @timcassell
    timcassell committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    bdf8e1c View commit details
    Browse the repository at this point in the history

  11. Use ConfigureAwait(false) on ValueTasks in AwaitHelper to preve… 

    …nt in-process deadlocks.
    @timcassell
    timcassell committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    39bdbea View commit details
    Browse the repository at this point in the history

  12. WIP 

    Refactored delegates to pass in IClock and return ValueTask<ClockSpan>.

TODO:
Fix compile errors from BenchmarkType.txt in NetFramework and Mono.
Update InProcessEmitBuilder for the new behavior.
    @timcassell
    timcassell committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    d505562 View commit details
    Browse the repository at this point in the history

  13. Fixed compile errors with .Net Framework and Mono runtimes. 

    Properly force unroll factor to 1.
Wait for Setup/Cleanup actions in engine.
    @timcassell
    timcassell committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    8bd8606 View commit details
    Browse the repository at this point in the history

  14. Update RunnableEmitter, WIP. 

    TODO: debug cause of crash
    @timcassell
    timcassell committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    24e5b01 View commit details
    Browse the repository at this point in the history

  15. Fixed crash

    @timcassell
    timcassell committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    c4030a7 View commit details
    Browse the repository at this point in the history

  16. Fixed InProcess (no emit) async tests.

    @timcassell
    timcassell committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    ddf5d0c View commit details
    Browse the repository at this point in the history

  17. Fixed unroll factor in InProcessNoEmit. 

    Fixed some EmitSameIL tests.
    @timcassell
    timcassell committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    ec917db View commit details
    Browse the repository at this point in the history

  18. Fixed InProcessEmitTests

    @timcassell
    timcassell committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    9025b27 View commit details
    Browse the repository at this point in the history

  19. Changed ManualResetValueTaskSource to AutoResetValueTaskSource.

    @timcassell
    timcassell committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    ac80032 View commit details
    Browse the repository at this point in the history

  20. Fixed errors after merge upstream.

    @timcassell
    timcassell committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    89efd0a View commit details
    Browse the repository at this point in the history

  21. Use ManualResetValueTaskSourceCore instead of copying source code.

    @timcassell
    timcassell committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    af29195 View commit details
    Browse the repository at this point in the history

  22. Fixed compile error after rebase.

    @timcassell
    timcassell committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    bdedcf9 View commit details
    Browse the repository at this point in the history