Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PackageIcon property #2008

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Use PackageIcon property #2008

merged 1 commit into from
Jun 23, 2022

Conversation

martincostello
Copy link
Member

Use PackageIcon instead of PackageIconUrl to resolve NU5048 warning.

Should unblock #1897.

Validated using NuGetPackageExplorer on a local package created with dotnet pack.

image

@martincostello
Use PackageIcon property
14dea59 
Use PackageIcon instead of PackageIconUrl.
adamsitnik
adamsitnik approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @martincostello !

@adamsitnik adamsitnik merged commit fcda33a into dotnet:master Jun 23, 2022
@martincostello martincostello deleted the Use-PackageIcon branch June 23, 2022 12:48
@AndreyAkinshin AndreyAkinshin added this to the v0.13.2 milestone Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamsitnik adamsitnik adamsitnik approved these changes

@AndreyAkinshin AndreyAkinshin Awaiting requested review from AndreyAkinshin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.13.2
Development

Successfully merging this pull request may close these issues.
3 participants
@martincostello @adamsitnik @AndreyAkinshin