Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for MonoVM to MemoryDiagnoser #2227

Merged
merged 3 commits into from
Dec 9, 2022
Merged

Add support for MonoVM to MemoryDiagnoser #2227

merged 3 commits into from
Dec 9, 2022

Conversation

adamsitnik
Copy link
Member

@adamsitnik adamsitnik commented Dec 9, 2022 •
edited
Loading

Sample results:

BenchmarkDotNet=v0.13.2.20221209-develop, OS=Windows 11 (10.0.22621.819)
AMD Ryzen Threadripper PRO 3945WX 12-Cores, 1 CPU, 24 logical and 12 physical cores
.NET SDK=8.0.100-alpha.1.22558.1
  [Host]     : .NET 7.0.1 (7.0.122.56804), X64 RyuJIT AVX2
  Job-TPQNZV : .NET 7.0.0 (7.0.22.42610) using MonoVM, X64 VectorSize=128

Runtime=Mono with .NET 7.0  Toolchain=Mono with .NET 7.0
Method Mean Error StdDev Gen0 Gen1 Gen2 Allocated
'new byte[10kB]' 5.751 us 0.1126 us 0.1156 us 0.5798 0.5798 0.5798 9.8 KB

@adamsitnik adamsitnik added this to the v0.13.3 milestone Dec 9, 2022
@adamsitnik adamsitnik mentioned this pull request Dec 9, 2022
Open
@adamsitnik adamsitnik merged commit 6992856 into master Dec 9, 2022
@adamsitnik adamsitnik deleted the monoImprovements branch December 9, 2022 13:28
timcassell
timcassell reviewed Dec 9, 2022
View reviewed changes
src/BenchmarkDotNet/Portability/RuntimeInformation.cs
}
}

return $".NET Core (Mono) {versionString}";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really supposed to be mono in the string from IsWasm?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently WASM is supported only by Mono VM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timcassell timcassell timcassell left review comments

Assignees
No one assigned
Labels
Area:Diagnosers
Projects
None yet
Milestone
v0.13.3
Development

Successfully merging this pull request may close these issues.
2 participants
@adamsitnik @timcassell