netcoreapp1.1 support for BenchmarkDotNet.Toolchains.Roslyn

[AndreyAkinshin]

For some reason, I couldn't install BenchmarkDotNet.Toolchains.Roslyn in a new netcoreapp1.1-application without this fix.

@adamsitnik, could you check the fix? Is everything ok?

[dnfclas]

Hi @AndreyAkinshin, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

[AndreyAkinshin]

Oh, my bad, we should reference BenchmarkDotNet.Toolchains.Roslyn only with net45 like in the samples project:

  "frameworks": {
    "net45": {
      "buildOptions": {
        "define": [ "CLASSIC" ]
      },
      "dependencies": {
        "BenchmarkDotNet.Toolchains.Roslyn": {
          "target": "project"
        }
      }
    },
    "netcoreapp1.1": {
      "buildOptions": {
        "define": [ "CORE" ]
      },
      "dependencies": {
        "BenchmarkDotNet.Core": {
          "target": "project"
        }
      }
    }
  }

We definitely need some templates for typical kinds of projects.

[adamsitnik]

We definitely need some templates for typical kinds of projects.

Our end users can simply install BenchmarkDotNet package, then nuget will resolve BenchmarkDotNet.Toolchains.Roslyn for Classic/Mono and skip it for .NET Core (we have no dependency to this package for our .NET Core build)

"frameworks": {
    "net45": {
      "buildOptions": {
        "define": [ "CLASSIC" ]
      },
      "dependencies": {
        "BenchmarkDotNet.Toolchains.Roslyn": {
          "target": "project"
        }
      }
    },
    "netcoreapp1.1": {
      "buildOptions": {
        "define": [ "CORE" ]
      },
      "dependencies": {
        "BenchmarkDotNet.Core": {
          "target": "project"
        }
      }
    }
  }

[mattwarren]

Hi @AndreyAkinshin, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! You've already signed the contribution license agreement. Thanks!

Hmm, I didn't realise this was in place. Does it mean that anyone contributing to BenchmarkDotNet has to sign a contributor license agreement?

[AndreyAkinshin]

@mattwarren, yes.