fix bold markup for Atlassian exporter #329
Conversation
|
Hi @lahma, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
|
@lahma, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
|
Hello, @lahma, I'm doing some refactoring in exporters right now. Could you send me the Attlassian spec you use? This will help me not to break your changes. |
|
@alinasmirnova here's the full markup guide: https://jira.atlassian.com/secure/WikiRendererHelpAction.jspa?section=all These work in both Confluence wiki and JIRA issue tracker. The relevant ones are noformat, tables and text effects (bold). |
| buffer.Append(markdownBold); | ||
| buffer.Append(line[columnIndex]); | ||
| buffer.Append(markdownBold); | ||
| buffer.Append(string.Format(boldMarkupFormat, line[columnIndex])); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@alinasmirnova don't you mind if I merge this PR now? |
lahma
force-pushed
the
features/atlassian-bold-format
branch
from
dc787d9
to
24dea48
Compare
|
@adamsitnik thanks for the review, I fixed the usage to use AppendFormat as you suggested. |
Atlassian uses single '*'s around text to make it bold where GitHub uses two. This fixes to allow customization of format for bold text which Atlassian exporter then overrides.