Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows picking showing and hiding measurement units in reports #413

Closed

Conversation

AmadeusW
Copy link
Contributor

@AmadeusW AmadeusW commented Apr 7, 2017

Introduces ISummaryStyle which can be added to the IConfig and to participating exporters (currently CsvExporter).

The style controls whether units appear in headers, whether they appear in the data and what are the units. If user did not specify units in the style, SummaryTable will set recommended units based on report results.

Participating implementations of IColumn (currently StatisticColumn and two AllocationColumn) render their headers and values based on ISummaryStyle

Closes #146 - Ability to specify units / easier comparison
Closes #118 - Raw data in CSV exports
Resolves a TODO in Windows.MemoryDiagnoser

This PR is a squashed version of #396

@dnfclas
Copy link

dnfclas commented Apr 7, 2017

@AmadeusW,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@AndreyAkinshin
Copy link
Member

@AmadeusW. you shouldn't create another PR for the squashed version. It's better to squash the summaryStyle branch and run git push -f; #396 will be automatically updated. It's better because it allows keeping the PR source code and the discussion in the same place. By the way, GitHub allows squashing on merge which is also a great feature.
It seems that we have some confilct in the ManualConfig file (probably because of recent @adamsitnik fixes). Could you resolve it?

@AmadeusW
Copy link
Contributor Author

Ok I'll go to #396, fix the conflict and you should be able to squash-merge, right?

@AmadeusW AmadeusW closed this Apr 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants