MarkdownExporter right-justifies numeric columns #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SteveDesmond-ca, |
|
my bad, apparently missed some implementations |
|
|
||
| private static string getDelimiterLineForColumn(SummaryTable.SummaryTableColumn column) | ||
| { | ||
| var justifier = column.Justify == SummaryTable.SummaryTableColumn.TextJustification.Left ? " " : ":"; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
|
||
| public SummaryTableColumn(SummaryTable table, int index, bool alwaysShow) | ||
| public SummaryTableColumn(SummaryTable table, int index, IColumn column) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@SteveDesmond-ca, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that #396 is complete, I've made a more complete pass at #398, to right-justify numeric columns in the
MarkdownExporter, which would resolve #397.IColumnhas a newIsNumericproperty, which is set (what I believe to be) appropriately in all its implementations.SummaryTableColumnusesIsNumericto set a newJustifyproperty to eitherLeftorRightMarkdownExporterusesJustifyto determine whether to use:or