Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false allocations detection #436

Merged
merged 1 commit into from
Apr 24, 2017
Merged

Fix false allocations detection #436

merged 1 commit into from
Apr 24, 2017

Conversation

ig-sinicyn
Copy link
Contributor

@ig-sinicyn ig-sinicyn commented Apr 24, 2017

Host.BeforeMainRun(); should run before gc stats init as some host implementations (in-process, as example) may allocate during notification.

UPD: Allocation in InProcessHost is triggered by WriteLine method:

                case HostSignal.BeforeMainRun:
                    diagnoser?.BeforeMainRun(diagnoserActionParameters);
                    WriteLine(Engine.Signals.BeforeMainRun);
                    break;

@AndreyAkinshin
Copy link
Member

@adamsitnik, could you take a look?

@adamsitnik adamsitnik merged commit ffd535a into dotnet:master Apr 24, 2017
@adamsitnik
Copy link
Member

good catch!

@AndreyAkinshin AndreyAkinshin added this to the v0.10.5 milestone Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants