-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add official copy of the Arcade templates that is compatible with 1ES… #14525
Merged
riarenas
merged 2 commits into
dotnet:main
from
riarenas:riarenas/add-official-templates
Feb 29, 2024
Merged
Add official copy of the Arcade templates that is compatible with 1ES… #14525
riarenas
merged 2 commits into
dotnet:main
from
riarenas:riarenas/add-official-templates
Feb 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pipeline templates schema
riarenas
requested review from
markwilkie,
dougbu,
AlitzelMendez,
mmitche and
chcosta
February 28, 2024 23:50
I'll try to come up with something to get us a decent diff between this and the unofficial templates to see what the actual changes were |
dougbu
previously approved these changes
Feb 29, 2024
jakubch1
approved these changes
Feb 29, 2024
I've been failing at this so far, still trying to get something easier to look at but I wouldn't wait on that. |
AlitzelMendez
previously approved these changes
Feb 29, 2024
chcosta
reviewed
Feb 29, 2024
chcosta
reviewed
Feb 29, 2024
mmitche
reviewed
Feb 29, 2024
mmitche
reviewed
Feb 29, 2024
mmitche
reviewed
Feb 29, 2024
mmitche
previously approved these changes
Feb 29, 2024
riarenas
dismissed stale reviews from mmitche, AlitzelMendez, and dougbu
via
February 29, 2024 21:51
2500833
dougbu
approved these changes
Feb 29, 2024
chcosta
approved these changes
Feb 29, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… pipeline templates schema
#14524
Adds a new set of templates that are compatible with the 1ES PT schema.
For now, these are mostly just a carbon copy of the public templates, some notable changes to show the kinds of improvements / cleanup we can make afterwards:
$(dncengpublicbuildpool)
variable.I used these templates to build Symreader here: https://dnceng.visualstudio.com/internal/_build/results?buildId=2390282&view=results
To double check: