Build outputs are not up-to-date inputs #14900
Conversation
| <_InputVSIXSourceItem Remove="$(IntermediateOutputPath)$(TargetName).pkgdef" /> | ||
| <_InputVSIXSourceItem Remove="@(_GeneratedExtensionJson)" /> | ||
|
|
||
| <UpToDateCheckInput Include="@(_InputVSIXSourceItem)" /> |
There was a problem hiding this comment.
what change does this make (Referring to all of the above)?
There was a problem hiding this comment.
Outputs of the current project build which are inputs to the VSIX are no longer treated as build inputs.
There was a problem hiding this comment.
Does this break incremental build when building VSIXs? What's the purpose of this change?
There was a problem hiding this comment.
This only affects whether the fast up-to-date check in Visual Studio thinks the project is up-to-date. Prior to our recent work on this target, there were significant cases where the project was not up-to-date but the build though it was. Then our original change went too far in the other direction, and now it thinks the build is out-of-date even right after a build.
There was a problem hiding this comment.
As long as it works, I'm fine with a workaround like this, but definitely need to get this fixed in VS SDK.
No description provided.