Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update internal mirror instructions #14906

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Update internal mirror instructions #14906

merged 3 commits into from
Jun 27, 2024

Conversation

sebastienros
Copy link
Member

No description provided.

@mmitche
Copy link
Member

mmitche commented Jun 27, 2024

Oh! Thanks!. This was on my todo list for later today.

@sebastienros
Copy link
Member Author

I supposed that it would not be that simple when I saw the same file for devdiv. Thanks for updating it directly, I wish I could approve but I can't.

@mmitche
Copy link
Member

mmitche commented Jun 27, 2024

Someone else will need to review because I can't approve either. @dougbu?

@riarenas
Copy link
Member

@mmitche your approval counts, but doc updates don't trigger CI, so the merge will need to bypass policies.

https://github.com/dotnet/arcade/blob/main/azure-pipelines-pr.yml#L9-L11

@mmitche
Copy link
Member

mmitche commented Jun 27, 2024

New changes require approval from someone other than mmitche because they were the last pusher.

@riarenas
Copy link
Member

weird, approved!

@mmitche mmitche requested a review from a team June 27, 2024 17:44
@mmitche mmitche merged commit be1b644 into main Jun 27, 2024
4 checks passed
@mmitche mmitche deleted the sebastienros-patch-1 branch June 27, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants