Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up SBOM generation #15014

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Fix up SBOM generation #15014

merged 2 commits into from
Aug 23, 2024

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Aug 20, 2024

It looks as though during the 1ESPT migration, we lost arcade's SBOM generation due to the steps not being included in the official job template. Because of how arcade handles artifacts, we do need our SBOM generation until 1ESPT handles pipeline logging command based uploads.

To double check:

It looks as though during the 1ESPT migration, we lost arcade's SBOM generation due to the steps not being included in the official job template. Because of how arcade handles artifacts, we do need our SBOM generation until 1ESPT handles pipeline logging command based uploads.
@mmitche mmitche requested a review from chcosta August 20, 2024 22:57
@mmitche
Copy link
Member Author

mmitche commented Aug 20, 2024

@chcosta can you take a look at this? It looks like we dropped SBOM generation, but not sure exactly how this was intended to be structured.

Copy link
Member

@chcosta chcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first comment is a bit of a nit. Setting this to "Request changes" only because I'd like Jeremy to validate he isn't affected by this before it gets merged.

eng/common/templates-official/job/job.yml Show resolved Hide resolved
eng/common/templates/job/job.yml Show resolved Hide resolved
chcosta
chcosta previously approved these changes Aug 21, 2024
@mmitche
Copy link
Member Author

mmitche commented Aug 21, 2024

@mmitche mmitche enabled auto-merge (squash) August 23, 2024 19:48
@mmitche
Copy link
Member Author

mmitche commented Aug 23, 2024

@chcosta can you approve?

@mmitche mmitche merged commit 9159926 into dotnet:main Aug 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants