Optprof download diagnosability #3974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases where the prefix is computed incorrectly, an official build failure is hard to diagnose because the console messages and warnings did not contain the queried path. Move the messages to an earlier point.
Create distinct errors for "no drops were found at all" and "no valid drops found".
jaredpar
approved these changes
Sep 18, 2019
livarcocc
approved these changes
Sep 18, 2019
tmat
approved these changes
Sep 18, 2019
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@rainersigwald - should this be merged? |
tmat
approved these changes
Jan 31, 2020
|
BTW, the IBC data acquisition produces a log:
This log contains details of what was downloaded from where and how. |
|
@JohnTortugo I'd say yes. I don't have permissions in this repo . . . |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@rainersigwald checks are passing, I'm merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MSBuild build broke as a result of the
Microsoftorganization moving tomicrosoft, which caused references to repo/branchname in OptProf artifact paths to change case, which resulted in empty query results on OptProf data (because it was published to, say,OptimizationData/Microsoft/msbuild/vs16.3instead ofOptimizationData/microsoft/msbuild/vs16.3, so the latter was empty).I think it would have taken us less time to figure out what was going on if things were logged this way rather than the existing way. I had to dig into binlogs each time to figure out what was being queried.