Wait to dispose RequestAborted CTS #4447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@muratg I would like to get this into a 2.2 patch. |
natemcmaster
suggested changes
Dec 5, 2018
There was a problem hiding this comment.
Can you make sure the affected assemblies are added to the list in https://github.com/aspnet/AspNetCore/blob/release/2.2/eng/PatchConfig.props?
Tratcher
approved these changes
Dec 5, 2018
halter73
force-pushed
the
halter73/4422
branch
from
f09c0ec
to
f15dc07
Compare
|
@natemcmaster It's nice not to have to switch repos anymore. |
natemcmaster
approved these changes
Dec 6, 2018
|
@halter73 Please add the shiproom template when you get the chance. Thanks! |
This was referenced Dec 6, 2018
vivmishra
added
Servicing-approved
|
Approved for 2.2.2. We will take the CoreCLR fix still in 2.2.1. |
halter73
force-pushed
the
halter73/4422
branch
from
1a82a86
to
c476f5e
Compare
|
Waiting for aspnet/AspNetCore-Internal#1610 to be resolved. |
dougbu
reviewed
Jan 15, 2019
eng/PatchConfig.props
Outdated
| @@ -20,6 +20,7 @@ Later on, this will be checked using this condition: | |||
| Microsoft.AspNetCore.Server.IIS; | |||
| Microsoft.AspNetCore.Server.IISIntegration; | |||
| Microsoft.AspNetCore.Server.IntegrationTesting.IIS; | |||
| Microsoft.AspNetCore.Server.Kestrel.Core; | |||
There was a problem hiding this comment.
No, your release/2.2 branch is behind. Please rebase then add this to the new block that's for 2.2.2.
halter73
force-pushed
the
halter73/4422
branch
2 times, most recently
from
f5a044c
to
bea1cf4
Compare
halter73
force-pushed
the
halter73/4422
branch
from
bea1cf4
to
3753de7
Compare
halter73
added a commit
that referenced
this pull request
Jan 18, 2019
muratg
added a commit
that referenced
this pull request
Jan 24, 2019
Revert "Wait to dispose RequestAborted CTS (#4447)"
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially Addresses #4422