[release/9.0] Fix ModelMetadata for TryParse-parameters in ApiExplorer #58372
+115
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the handling for schemas associated with types that implement a custom TryParse and are consumed from either the route or query string.
Fixes #58318
Customer Impact
Without this change, APIs that bind parameters from the query string or URL will produce invalid schemas if the type being bound to implements a
TryParse
method or theIParsable
interface.There are workarounds for this scenario (using schema transformers) but it requires users add a fair bit of code in their own applications and this fix is small enough to warrant improving the QoL for this.
Example of impacted scenario
Regression?
Risk
Change localized to OpenAPI support + TryParsable parameters in the route query.
Verification
Packaging changes reviewed?