Wait to dispose CTS for IIS #9389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will also address some gaps we had between Kestrel and IIS, specifically not cancelling the cts after writing the entire content and checking content length. |
halter73
reviewed
Apr 15, 2019
src/Servers/IIS/IIS/src/Core/IISHttpContext.IHttpRequestLifetimeFeature.cs
Outdated
Show resolved
Hide resolved
halter73
reviewed
Apr 15, 2019
src/Servers/IIS/IIS/src/Core/IISHttpContext.IHttpRequestLifetimeFeature.cs
Outdated
Show resolved
Hide resolved
halter73
reviewed
Apr 15, 2019
halter73
reviewed
Apr 15, 2019
halter73
reviewed
Apr 15, 2019
halter73
reviewed
Apr 15, 2019
halter73
reviewed
Apr 15, 2019
halter73
approved these changes
Apr 15, 2019
|
File an issue for creating a LazyResettableCts type so we can backlog it 😉 |
Tratcher
approved these changes
Apr 15, 2019
|
Debugging the inproc failure with NTLM tests. Seems like there was a failed request. |
|
Figured it out, bad check for requestAborted. |
halter73
reviewed
Apr 16, 2019
src/Servers/IIS/IIS/src/Core/IISHttpContext.IHttpRequestLifetimeFeature.cs
Outdated
Show resolved
Hide resolved
|
@javiercn https://dev.azure.com/dnceng/public/_build/results?buildId=157804 |
|
Never seen that one before. |
|
That's in SignalR (cc @mikaelm12) Doesn't seem like something we can control... |
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4422
Fixes https://github.com/aspnet/AspNetCore-Internal/issues/1831
Still have a few tests I need to write. Will mark ready for review when appropriate.
@halter73 I lightly explored making a helper for safe disposal/cancellation, and it didn't look great. I'm going to keep them separate for now.