Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Fix dependency context builder regression #1750

Merged
merged 1 commit into from
Mar 9, 2016

Conversation

pakrym
Copy link

@pakrym pakrym commented Mar 8, 2016

Fix regression in dependency builder when having multiple dependencies with same name.
@anurse

@analogrelay
Copy link

:shipit: when builds succeed

@pranavkm
Copy link

pranavkm commented Mar 8, 2016

Any idea where the IDictionary<>.Add call is? Could we change that to indexer assignment so it doesn't throw?

@pakrym
Copy link
Author

pakrym commented Mar 8, 2016

I wasn't dictionary add call it's Can not add property System.Collections to Newtonsoft.Json.Linq.JObject. Property with the same name already exists on object. thrown at https://github.com/dotnet/cli/blob/pakrym/deps-duplication-fix/src/Microsoft.Extensions.DependencyModel/DependencyContextWriter.cs#L246

@troydai
Copy link

troydai commented Mar 8, 2016

:shipit:

1 similar comment
@pranavkm
Copy link

pranavkm commented Mar 8, 2016

:shipit:

@davidfowl
Copy link
Member

When does this happen?

@pakrym
Copy link
Author

pakrym commented Mar 8, 2016

Won't merge per @davidfowl request, we'll need to fix root cause

@pakrym pakrym closed this Mar 8, 2016
@leecow leecow removed the in progress label Mar 8, 2016
@pakrym pakrym reopened this Mar 9, 2016
pakrym added a commit that referenced this pull request Mar 9, 2016
Fix dependency context builder regression
@pakrym pakrym merged commit 85b7336 into rel/1.0.0 Mar 9, 2016
@leecow leecow removed the in progress label Mar 9, 2016
@eerhardt eerhardt deleted the pakrym/deps-duplication-fix branch May 4, 2016 22:07
wli3 pushed a commit to wli3/cli that referenced this pull request Nov 14, 2018
This implements the feature described in dotnet#1750. It provides projects with a way to
explicitly opt-out of implicit transitive refernces by setting the
DisableImplicitTransitiveReferences property to `'true'`.

closes dotnet#1750
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants