This repository has been archived by the owner on Apr 20, 2023. It is now read-only.
Defend against forthcoming breaking change in SDK #8409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguerrera
force-pushed
the
defend-against-breaking-change
branch
from
188a28e
to
c75ef2e
Compare
livarcocc
approved these changes
Jan 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a couple of places where our custom build steps were reaching in to the items produced by RunResolvePackageDependencies.
This target will not be run by default with dotnet/sdk#1857. Changing the code now to a form that works before and after that change so that we don't hit the break when an SDK insertion becomes the new stage0.
(There are better ways to write these with the new items, but this is the easiest way to make the code work before and after the change.)