This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
[master] Updating CoreFx, CoreClr, Standard to beta-25022-02, beta-25101-04, beta-25101-03 respectively #1604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eta-25101-03 respectively
|
Auto-PR went through, triggered by a dotnet/standard build. @gkhanna79 @ericstj |
|
@gkhanna79 it looks like the coreclr package Core-setup is expecting |
|
That AnyCPU sounds like what I saw in dotnet/coreclr#9664. @chcosta |
|
Yeah, I think that was a regression from dotnet/coreclr#9263 that was likely provoked by my feedback. @chcosta can you look into fixing up the value of CrossTargetComponentFolder in CoreCLR? I'll put a workaround in place in this branch. |
ericstj
force-pushed
the
UpdateDependencies20170301081800
branch
from
e7629a8
to
c171cf2
Compare
https://github.com/dotnet/coreclr/issues/9884 is causing crossgen.exe to be in the wrong folder. Temporarily pick it up from there until that issue is fixed.
ericstj
force-pushed
the
UpdateDependencies20170301081800
branch
from
c171cf2
to
e8d784d
Compare
ericstj
reviewed
Mar 1, 2017
| ridCrossgen = Path.Combine(crossgenPackagePath, "tools", "x64_arm64", $"crossgen{Constants.ExeSuffix}"); | ||
| // workaround https://github.com/dotnet/coreclr/issues/9884 | ||
| // ridCrossgen = Path.Combine(crossgenPackagePath, "tools", "x86_arm", $"crossgen{Constants.ExeSuffix}"); | ||
| ridCrossgen = Path.Combine(crossgenPackagePath, "tools", "x86_AnyCPU", $"crossgen{Constants.ExeSuffix}"); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @dotnet/core-setup-contrib