Add a GC Reliability Framework job to the CI #11280
Conversation
|
@dotnet-bot test CI please |
|
@dotnet-bot test CI please |
1 similar comment
|
@dotnet-bot test CI please |
|
@sergiy-k @Maoni0 @adityamandaleeka PTAL? Not sure who reviews CI changes. I was having trouble running the RF on a new Linux VM yesterday, so that will probably require some additional investigation outside of this PR. OSX and Windows should both be able to run without problems, though - I ran this on both of those machines and didn't have trouble. (Though, you never know with CI... even if it works on my machine.) |
|
@ramarag are you the right person to review this? |
|
last i heard @mmitche was the expert on the CI |
|
are there any objections to this PR? I think it's ready to merge otherwise - it shouldn't have any effect on currently-running CI jobs. |
|
has @mmitche reviewed? |
|
Not yet - @mmitche, do you mind taking look? |
|
@dotnet-bot test ci please |
1) To address offline feedback, update the CI trigger phase document and the GC testing instructions 2) Set the timeout for GC RF CI jobs to 24 hours, so they don't time out (they will run for 15 hours by default) 3) Refactor "scenario == 'gc_reliability_framework' to its own method so that new GC RF scenarios can easily and cleanly be added if desired in the future
|
@dotnet-bot test CI please |
|
@mmitche ping - do you mind taking a look if you get a minute? |
|
@dotnet-bot test ci please |
|
LGTM |
|
thanks! |
This PR adds a new job,
gc_reliability_framework, that can be requested on PRs via its trigger phrase. I've left it as a PR trigger-phrase job only for now until it's verified that it works - after that, we could run it at a more regular cadence.The job will do a build and run the GC Reliability Framework on the CI machine, which runs for quite a long time and runs several tests simultaneously within the same process. It's found many bugs in the past and is generally very useful validation that recently has been done manually.
This PR also fixes an issue where the Standalone GC CI job couldn't be triggered through PR trigger phrases.
Fixes https://github.com/dotnet/coreclr/issues/4534.