This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Fix Platform reporting parameters for build pipeline #12900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattGal
approved these changes
Jul 19, 2017
There was a problem hiding this comment.
LGTM, but consider actually using "Architecture" everywhere then updating the view config
- Edit: You probably need to use architecture everywhere (https://github.com/dotnet/core-eng/blob/master/mission-control-config/dotnet/coreclr/viewconfiguration.json)
|
We should change the view config if we can, because that will fix old builds too (and across all the various branches). Changing this means old builds will still use a weird version an not line up with newer builds for any historical data we might want to mine. |
|
@ChadNedzlek I agree and should probably keep using the wrong properties, but we do need to plumb the wrong properties through to all the jobs so they show up. |
|
Oh, yes, I didn't notice the last two were adds instead of changes. Agreed. |
|
Reverted back to Architecture and added the missing params. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly report platform data
Distinguish the two different sets of Windows test builds
/cc @MattGal @wtgodbe