This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
[x86/Linux][SOS] Fix clrstack command of lldb sosplugin on x86 #13973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbaladurin
force-pushed
the
x86-sosplugin-clrstack
branch
2 times, most recently
from
b74651a
to
4be9ee2
Compare
|
@dotnet-bot test Ubuntu x64 Checked Build and Test |
|
@mikem8361 @janvorli PTAL |
mikem8361
approved these changes
Sep 15, 2017
|
@dotnet-bot test Ubuntu x64 Checked Build and Test |
added 5 commits
October 2, 2017 08:38
It's need for 'clrstack -f' command of SOS plugin on x86.
We should use PTR_UNWIND_INFO instead of PUNWIND_INFO for pointer to UNWIND_INFO structure because it's pointer from other process and we need to use DAC to read data using it.
It's needed for 'clrstack -f' command in libsosplugin.
Asm block like following: __asm fnsave currentFPUState where currentFPUState is structure works with MSVC but leads to undefined reference currentFPUState in the binary with other compilers. So rewrite such asm blocks for them. This patch fixes error "Unable to load 'libmscordbi.so'" during execution of 'clrstack -f' command of SOS plugin on x86.
WINAPI and STDAPI are defined as __cdecl but in some cases functions with these attributes are called using stdcall calling convention. It leads to crashes during execution of 'clrstack -i' command of SOS plugin on x86.
kbaladurin
force-pushed
the
x86-sosplugin-clrstack
branch
from
4be9ee2
to
b01cf77
Compare
|
@janvorli PTAL |
|
@janvorli thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes
clrstackcommand of lldb sosplugin on x86.