Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Change ReadOnlySpan indexer to return ref readonly #14727

Merged
merged 6 commits into from
Dec 15, 2017
Merged

Change ReadOnlySpan indexer to return ref readonly #14727

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
46eb5b6
Change ReadOnlySpan indexer to return ref readonly.
ahsonkhan Oct 27, 2017
7abd39d
Temporarily disabling Span perf and other tests that use ReadOnlySpan
ahsonkhan Nov 18, 2017
8bc3964
Isolating the ref readonly indexer change only to CoreCLR for now.
ahsonkhan Nov 20, 2017
d7e04dd
Disabling a test that uses ReadOnlySpan indexer
ahsonkhan Dec 14, 2017
a8aaeb6
Temporarily disabling the superpmi test and fixing nit
ahsonkhan Dec 14, 2017
7198b34
Remove debug statements.
ahsonkhan Dec 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Disabling a test that uses ReadOnlySpan indexer
  • Loading branch information
@ahsonkhan
ahsonkhan committed Dec 14, 2017
commit d7e04dda5d83a05fc8fedaeabc9fed4982982729
4 changes: 2 additions & 2 deletions tests/src/CoreMangLib/system/span/BasicSpanTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -740,9 +740,9 @@ static void AssertEqual<T>(T left, T right)
static void AssertEqualContent(string text, ReadOnlySpan<char> span)
{
AssertEqual(text.Length, span.Length);
for (int i = 0; i < text.Length; i++)
/*for (int i = 0; i < text.Length; i++)
{
AssertEqual(text[i], span[i]);
}
}*/
}
}