This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Update profiling API status #15659
Merged
Update profiling API status #15659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sywhang
added
area-Diagnostics
documentation
jkotas
reviewed
Jan 2, 2018
| @@ -16,6 +18,10 @@ The implementation of this API was making some questionable assumptions about Wi | |||
|
|
|||
| See github issue [#13153](https://github.com/dotnet/coreclr/issues/13153) for more details. | |||
|
|
|||
| ### ReJIT on ARM | |||
|
|
|||
| ReJIT optimizations are only available on x86/x64 for now. | |||
There was a problem hiding this comment.
Does this mean that the feature works fine, but it has worse performance than on x86/x64?
There was a problem hiding this comment.
Oh. I meant that ReJIT feature itself is not working on ARM. I'll change the word "optimizations" to "feature" to avoid ambiguity. Thank you!
noahfalk
reviewed
Jan 5, 2018
| @@ -16,6 +18,10 @@ The implementation of this API was making some questionable assumptions about Wi | |||
|
|
|||
| See github issue [#13153](https://github.com/dotnet/coreclr/issues/13153) for more details. | |||
|
|
|||
| ### ReJIT on ARM | |||
|
|
|||
| ReJIT feature is only available on x86/x64 for now. | |||
There was a problem hiding this comment.
Lets open an issue that tracks this and link it here.
|
LGTM, modulo my one comment |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platform testing for Windows/Linux on arm32 as well as OSX have been completed. Updating the documentation to reflect this change.